Develop Bugs

[Q] RIL Development sgh-t999

Hi everyone,
recently I have built and flashed on my sgh-t999 (galaxy S3 US tmobile version) CM11 Nightly. For my pro0ject however I need to modify two libraries of the Radio Interface Layer (RIL), libril.so and libreference-ril.so. I tried to modify the ones in the forlder /hardware/ril/ and build everything again with no results. Any change that I made to those files (such as ril.cpp in the folder libril) would not affect the functionality of the phone.
Finally yesterday I understood that when I build those libraries for the target cm-d2tmo-eng, those files that I have modified are not considered at all! When the libraries are built indeed, the system automatically takes the libril.so and libreference.so present in the vendor folder!
The problem is that those libraries in the vendor folder and already compiled and I cannot modify them. The question is:
Is there any way that I compile those libraries from the source code that I have modified?
Thanks,
brok85

Given that there is a unified D2LTE Build on CM, can you elaborate on what changes you wish to make to these libraries ?
To answer your question, You can do one of two things.
Grab the CM Source Code from the Device Tree of D2LTE. Make your relevant changes and check in the changes if they boot ok on your device. That way those changes will be included in future builds of CM and other Roms that use it.
If you do not wish to do so, then you will have to compile those libraries using C++ Compiler on a *NIX box and replace them in the Vendor folder.

Perseus71 said:
Given that there is a unified D2LTE Build on CM, can you elaborate on what changes you wish to make to these libraries ?
Click to expand...
Click to collapse
Well, as fisrt I just wanted to insert some log to be able to follow the code execution from the logcat or do something similar.
Perseus71 said:
To answer your question, You can do one of two things.
Grab the CM Source Code from the Device Tree of D2LTE. Make your relevant changes and check in the changes if they boot ok on your device. That way those changes will be included in future builds of CM and other Roms that use it.
Click to expand...
Click to collapse
Sorry but I am kind of new on this things. I have already downloaded the source code from the device tree and made my modifications in the files ril.cpp contained in [path-to-android-source]/hardware/ril/libril/ril.cpp. What I did was commenting the whole code within the function RIL_onUnsolicitedResponse() and listenCallback() such that in theory, the phone is not able to display incoming calls for example. However after flashing the re-built android I am still able to receve calls. How can I "check in the changes if they boot ok on my device"?
Perseus71 said:
If you do not wish to do so, then you will have to compile those libraries using C++ Compiler on a *NIX box and replace them in the Vendor folder.
Click to expand...
Click to collapse
I tried to remove the libril.so in the vendor folder and compile again using
# . build/envsetup.sh
# lunch (and select d2tmo)
# mmm [path-to-android-source]/hardware/ril/libril".
The problem is that when I indicate the target after lunch, the compiler looks for the vendor libraries and stop the build. What I am doing wrong?

Sounds like Compiler Dependacy path is set different from the code base. I will look further before commenting.
For when your changes are for the benefit of the community of users, you check in the changed code back to the Device Tree with detailed comments within the code and while checking in.

Perseus71 said:
Given that there is a unified D2LTE Build on CM, can you elaborate on what changes you wish to make to these libraries ?
To answer your question, You can do one of two things.
Grab the CM Source Code from the Device Tree of D2LTE. Make your relevant changes and check in the changes if they boot ok on your device. That way those changes will be included in future builds of CM and other Roms that use it.
If you do not wish to do so, then you will have to compile those libraries using C++ Compiler on a *NIX box and replace them in the Vendor folder.
Click to expand...
Click to collapse
Perseus71 said:
Sounds like Compiler Dependacy path is set different from the code base. I will look further before commenting.
For when your changes are for the benefit of the community of users, you check in the changed code back to the Device Tree with detailed comments within the code and while checking in.
Click to expand...
Click to collapse
Actually this is what I get after deleting
libril.so in vendor/samsung/d2tmo/proprietary/lib/
and after executing mmm /hardware/ril/libril :
No private recovery resources for TARGET_DEVICE d2tmo
make: *** No rule to make target `vendor/samsung/d2tmo/proprietary/lib/libril.so', needed by `/home/brok85/Documents/android/system/out/target/product/d2tmo/system/lib/libril.so'. Stop.
make: Leaving directory `/home/brok85/Documents/android/system'

If u want to build from source, delete the line that copies in vendor-blobs.mk
If u want to copy the blob instead of building it from source, keep the line
It'll be better if u provide us the device and vendor trees links

blackbeard said:
If u want to build from source, delete the line that copies in vendor-blobs.mk
If u want to copy the blob instead of building it from source, keep the line
It'll be better if u provide us the device and vendor trees links
Click to expand...
Click to collapse
I am not sure to understand what should I provide Sorry, as I said I'm kind of new here...
Also, I can not find vendor-blobs.mk...Where it should be?

brok85 said:
I am not sure to understand what should I provide Sorry, as I said I'm kind of new here...
Also, I can not find vendor-blobs.mk...Where it should be?
Click to expand...
Click to collapse
You said you built a cm11 for ur device. So for that you needed the device and the vendor trees. Give the link of those, if they are on the git
And vendor-blobs.mk would be present in the vendor folder under your device folder

blackbeard said:
You said you built a cm11 for ur device. So for that you needed the device and the vendor trees. Give the link of those, if they are on the git
Click to expand...
Click to collapse
Well I have followed the guide in the following page
http://wiki.cyanogenmod.org/w/Build_for_d2tmo
The link from where I have obtained the repository is
$ repo init -u git://github.com/CyanogenMod/android.git -b cm-11.0
and then
$ breakfast d2tmo
blackbeard said:
And vendor-blobs.mk would be present in the vendor folder under your device folder
Click to expand...
Click to collapse
Actually now I think I was able to compile the library following your instructions. Unfortunatly, when I have built and flashed everything in the galaxy S3, I was not able to use the network. Probably some compatibility issue?
When I compiled libril.so, I have obtained it from the folder /hardware/ril/libril which should contain google source code, maybe not compatibale with my device...is it right?
thanks a lot for the help guys

brok85 said:
Actually now I think I was able to compile the library following your instructions. Unfortunatly, when I have built and flashed everything in the galaxy S3, I was not able to use the network. Probably some compatibility issue?
When I compiled libril.so, I have obtained it from the folder /hardware/ril/libril which should contain google source code, maybe not compatibale with my device...is it right?
Click to expand...
Click to collapse
You know, silly question. But just so we can rule out. Did you at any point compiled the CM11 code as is and flashed to the phone ? How did Network behave ? Was everything ok ?
Galaxy S3 is a very open platform with standard hardware and chipsets. So the Default google code should work out of box with it. If you have network issues, then just for kicks you can flash a custom Kernel on top of your compiled CM 11. See how that goes.

Perseus71 said:
You know, silly question. But just so we can rule out. Did you at any point compiled the CM11 code as is and flashed to the phone ? How did Network behave ? Was everything ok ?
Click to expand...
Click to collapse
No silly question at all
I have compiled CM11 as it is and worked perfectly. I could use the network.
Perseus71 said:
Galaxy S3 is a very open platform with standard hardware and chipsets. So the Default google code should work out of box with it. If you have network issues, then just for kicks you can flash a custom Kernel on top of your compiled CM 11. See how that goes.
Click to expand...
Click to collapse
The procedure I have followed is the following one:
1) Delete the llibril.so and libreference-ril.so from the vendor library. These are the pre-compiled vendor libraries that I need to modify.
2) commented the lines from the vendor-blobs.mk that were including those two precompiled libraries.
3) go to android/system/ and run "mmm /hardware/ril/libril" and "mmm /hardware/ril/reference-ril" to obtain the modified libril.so and libreference-ril.so respectively.
4) copied the new libraries just obtained in the vendor folder where the pre-compiled libraries were
5) re-include the lines commented in point 2).
6) run brunch d2tmo
7) flash the .zip obtained
Any mistake?

Perseus71 said:
You know, silly question. But just so we can rule out. Did you at any point compiled the CM11 code as is and flashed to the phone ? How did Network behave ? Was everything ok ?
Click to expand...
Click to collapse
No silly question at all. Yes I have built everything out of the box and worked perfectly. I could use the network.
Perseus71 said:
Galaxy S3 is a very open platform with standard hardware and chipsets. So the Default google code should work out of box with it. If you have network issues, then just for kicks you can flash a custom Kernel on top of your compiled CM 11. See how that goes.
Click to expand...
Click to collapse
I followed the following procedure to include my modified libraries:
1) Eliminate precompiled vendor libraries: libril.so and libreference-ril.so from the vendor folder
2) comment lines in the vendor-blobs.mk that included those two precompiled libraries
3) from /android/system/ executed command "mmm /hardware/ril/librail" and "mmm /hardware/ril/reference-ril" to obtain the modified libril.so and libreference-ril.so
4) copied the new libraries in the vendor folder in the same places were the precompiled libraries were positioned
5) re-include the two lines that were commented in point 2)
6) build everything again with brunch d2tmo
7) flash the .zip obtained
Any mistake?

Unless I am having a brain fart that process seems about right. I wonder if your RIL changes are related to the network
What kind of issues do you see ?

Perseus71 said:
Unless I am having a brain fart that process seems about right. I wonder if your RIL changes are related to the network
What kind of issues do you see ?
Click to expand...
Click to collapse
It cannot even find the network operators. It says that it is impossible to connect and to try later...
mine is the Tmobile version of S3. May this influence?

That would depend on the changes you made. But otherwise not really. The underlying Device tree is unified for all US S3 devices.

How to Build AOSB from source

I am wanting to build AOSB from source with newer CM 11 as base
How do I build it repo is https://github.com/AOSB?page=1
Many thanks hope someone can help please

anttaz said:
I am wanting to build AOSB from source with newer CM 11 as base
How do I build it repo is https://github.com/AOSB?page=1
Many thanks hope someone can help please
Click to expand...
Click to collapse
Assume you have setup build environment.
1. Repo init AOSB source
2. [email protected] device/htc/endeavoru, device/htc/tegra3-common, vendor/htc, kernel/htc to appropriate path.
3. Modify .mk file in device/htc/endeavoru per AOSB
Hint : maybe you also need more missing repo in AOSB from CM..especially wifi stuff

yes ubuntu build environment set up just need to know how to build. I am a bit of a newbie to Android, Many thanks for the response

audahadi said:
Assume you have setup build environment.
1. Repo init AOSB source
2. [email protected] device/htc/endeavoru, device/htc/tegra3-common, vendor/htc, kernel/htc to appropriate path.
3. Modify .mk file in device/htc/endeavoru per AOSB
Hint : maybe you also need more missing repo in AOSB from CM..especially wifi stuff
Click to expand...
Click to collapse
yes ubuntu build environment set up just need to know how to build. I am a bit of a newbie to Android, Many thanks for the response

Read some guide to understand a bit about build process.XDA university @ CM wiki have lot of resources.
repo init -u https://github.com/AOSB/android.git -b cm-11.0
They have crap commit for newbie to build..hope that link work.
After you have all device tree setup properly.
.build/envsetup.sh && brunch endeavoru

audahadi said:
Read some guide to understand a bit about build process.XDA university @ CM wiki have lot of resources.
repo init -u https://github.com/AOSB/android.git -b cm-11.0
They have crap commit for newbie to build..hope that link work.
After you have all device tree setup properly.
.build/envsetup.sh && brunch endeavoru
Click to expand...
Click to collapse
404 this is not the page you are looking for?

audahadi said:
Read some guide to understand a bit about build process.XDA university @ CM wiki have lot of resources.
repo init -u https://github.com/AOSB/android.git -b cm-11.0
They have crap commit for newbie to build..hope that link work.
After you have all device tree setup properly.
.build/envsetup.sh && brunch endeavoru
Click to expand...
Click to collapse
Read up I just don't get the device tree part of it now?

anttaz said:
Read up I just don't get the device tree part of it now?
Click to expand...
Click to collapse
Compare with other AOSB devices..what they change @ needed to compile for AOSB.

audahadi said:
Compare with other AOSB devices..what they change @ needed to compile for AOSB.
Click to expand...
Click to collapse
Well no luck as no other devices have a guide on building and asking the chefs of the ROMs on xda and on official asob site no response other than yourself. So still none the wiser

audahadi said:
Compare with other AOSB devices..what they change @ needed to compile for AOSB.
Click to expand...
Click to collapse
I have the manifest xml now will this help in the building process?

anttaz said:
I have the manifest xml now will this help in the building process?
Click to expand...
Click to collapse
Should be similar to this
http://wiki.cyanogenmod.org/w/Endeavoru_Info
Honestly..their source is crap..can't find much information to help you with. Just use another rom..

audahadi said:
Should be similar to this
http://wiki.cyanogenmod.org/w/Endeavoru_Info
Honestly..their source is crap..can't find much information to help you with. Just use another rom..
Click to expand...
Click to collapse
Many thanks for all your help anyways. Much appreciated

delete

Delete this thread

Well, i suddenly visited Mipad sub-forum on XDA and i saw this...
What? You just rename repository from android_device_nvidia_shieldtablet to android_device_xiaomi_mocha...
And it is ALL what you did ???? OMG. No comments. Facepalm.
So i spent 1 hour of my life to make a mocha bring up.
https://github.com/vickdu31/android_device_xiaomi_mocha/pull/1/files
Also you should merge commits which will update selinux to kernel sources.
+ Do not forget about upstream patches.
Cherry-pick it from
https://github.com/CyanogenMod/android_kernel_nvidia_shieldtablet
If YOU continue do nothing, you will receive no result.

tank0412 said:
Well, i suddenly visited Mipad sub-forum on XDA and i saw this...
What? You just rename repository from android_device_nvidia_shieldtablet to android_device_xiaomi_mocha...
And it is ALL what you did ???? OMG. No comments. Facepalm.
So i spent 1 hour of my life to make a mocha bring up.
https://github.com/vickdu31/android_device_xiaomi_mocha/pull/1/files
Also you should merge commits which will update selinux to kernel sources.
+ Do not forget about upstream patches.
Cherry-pick it from
https://github.com/CyanogenMod/android_kernel_nvidia_shieldtablet
If YOU continue do nothing, you will receive no result.
Click to expand...
Click to collapse
Don't blame him. There is a will and intention of him to cook a rom. Everybody needs help and everybody was a beginner.

Yeah I have been pretty busy at school and other stuff so I don't have time, and still I have to learn couple things, I pulled the request, thanks.
I did this in this time : http://gbatemp.net/threads/release-haxchi-installer-1-1-noob-friendly.448890/
I think there is no big hurry and I am really busy at the moment, my point is to get more people working and ofcourse I have to start working on it asap !

There are people working
They just don't open a thread without having done anything because that's not really development

Harrynowl said:
There are people working
They just don't open a thread without having done anything because that's not really development
Click to expand...
Click to collapse
Can't find anyone working on it.. Is there any thread, forum or group or anything where people work ? Even on github I didnt find anything

vickdu31 said:
Can't find anyone working on it.. Is there any thread, forum or group or anything where people work ? Even on github I didnt find anything
Click to expand...
Click to collapse
Yes, it could be great to join your effort to not repeat same work.
Regards.

vickdu31 said:
Can't find anyone working on it.. Is there any thread, forum or group or anything where people work ? Even on github I didnt find anything
Click to expand...
Click to collapse
@Harrynowl is working as far as I know. I'm too but very busy lately.

Status !!?
vickdu31 said:
I create this thread to gather all potential developpers to join me and try to build a CM13.0 (at least a build that boot) for our Mi Pad.
I don't have much experience or knowledge yet but who knows, maybe we can get bootable build soon or later.
To all users : Do not expect anything from this thread in a while.
Current situation :
Just created the device tree from Nexus and Xiaomi sources.
To do right now :
- Totally modify the Device Tree (this is from nexus 9)
- Modify kernel to be able to try to even build something
Here are the device tree :
Device Tree (from cm13 Nexus 9) : https://github.com/vickdu31/android_device_xioami_mocha
Kernel Tree (from Xiaomi KK) : https://github.com/vickdu31/android_kernel_xiaomi_mocha
Vendor Tree (old Xiaomi KK) : https://github.com/vickdu31/android_vendor_xiaomi_mocha
I think I cannot do everything all by myself within 6+ month so any help is very welcome just as pull requests.
XDA:DevDB Information
working on Mi Pad, ROM for the Xiaomi Mi Pad
Contributors
vickdu31
ROM OS Version: 6.0.x Marshmallow
ROM Kernel: Linux 3.10.x
Based On: CyanogenMod
Version Information
Status: Testing
Created 2016-11-21
Last Updated 2016-11-26
Click to expand...
Click to collapse
Any progress to look forward to ?

Required help
Can some one guide me through the process of building the rom i already downloaded the cm 13 source. Searched many forums but not able to understand the process how to build for mocha @tank0412 @vickdu31 @Harrynowl

Rohit99 said:
Can some one guide me through the process of building the rom i already downloaded the cm 13 source. Searched many forums but not able to understand the process how to build for mocha @tank0412 @vickdu31 @Harrynowl
Click to expand...
Click to collapse
OMG.
Are you seriously?
. build/envsetup.sh
lunch
*enter number of mochas lunch combo"

You cannot build with these device sources because they are broken

Error while building
tank0412 said:
OMG.
Are you seriously?
. build/envsetup.sh
lunch
*enter number of mochas lunch combo"
Click to expand...
Click to collapse
Got this error while building using command
Code:
brunch mocha
including vendor/cm/vendorsetup.sh
build/core/product_config.mk:234: *** Can not locate config makefile for product "cm_mocha". Stop.
Device mocha not found. Attempting to retrieve device repository from CyanogenMod Github (http://github.com/CyanogenMod).
Repository for mocha not found in the CyanogenMod Github repository list. If this is in error, you may need to manually add it to your local_manifests/roomservice.xml.
build/core/product_config.mk:234: *** Can not locate config makefile for product "cm_mocha". Stop.
** Don't have a product spec for: 'cm_mocha'
** Do you have the right repo manifest?
Click to expand...
Click to collapse
added repos in local_manifest.xml and roomservice.xml
Update :
i was able to brunch but stuck at this error
make: *** No rule to make target 'kernel/xiaomi/mocha/arch/arm/configs/cyanogenmod_mocha_defconfig', needed by '/home/uttara/rom/script/out/target/product/mocha/obj/KERNEL_OBJ/.config'. Stop.
make: *** Waiting for unfinished jobs....
Click to expand...
Click to collapse
@tank0412 please help

Rohit99 said:
Got this error while building using command
Code:
brunch mocha
added repos in local_manifest.xml and roomservice.xml
Update :
i was able to brunch but stuck at this error
@tank0412 please help
Click to expand...
Click to collapse
OMG. Are you seriously?
Put kernel sources to 'kernel/xiaomi/mocha/
It was writtent in the error!
No comments....
And rename defconfig of mocha to cyanogenmod_mocha_defconfig

tank0412 said:
OMG. Are you seriously?
Put kernel sources to 'kernel/xiaomi/mocha/
It was writtent in the error!
No comments....
And rename defconfig of mocha to cyanogenmod_mocha_defconfig
Click to expand...
Click to collapse
@tank0412 I'm very sorry for disturbing you this is my first build so please help, should i rename tegra_defconfig bcoz there is no file named defconfig

Rohit99 said:
@tank0412 I'm very sorry for disturbing you this is my first build so please help, should i rename tegra_defconfig bcoz there is no file named defconfig
Click to expand...
Click to collapse
Oh, GOD.
Check this:
https://github.com/vickdu31/android_kernel_xiaomi_mocha/pull/1/files
And turn on logic

Im working on other projects now, I don't have time at all, I can pull commits, I was thinking about closing this thread but since we can talk I can keep it open, but a discusion thread would be more apropriate

vickdu31 said:
Im working on other projects now, I don't have time at all, I can pull commits, I was thinking about closing this thread but since we can talk I can keep it open, but a discusion thread would be more apropriate
Click to expand...
Click to collapse
@vickdu31 you can close the thread i have created a new thread CM13

ParanoidAndroid build error

Hello, guys.
I have a problem with building Paranoid on my D855 device, here's a log: https://pastebin.com/raw/EUZfeFgg
I put https://github.com/xiaolu/mkbootimg_tools already and that fixed dt.img problem, but there's next one with ramdisk-recovery.img (or recovery.img).
Can you help me?

What was your first error, show your device and common tree, show your local_manifest.

ppajdek said:
What was your first error, show your device and common tree, show your local_manifest.
Click to expand...
Click to collapse
the first error was the same, but instead of ramdisk-recovery.img/recovery.img was just dt.img
https://github.com/LineageOS/android_device_lge_d855
https://github.com/LineageOS/android_device_lge_g3-common
https://github.com/LineageOS/android_kernel_lge_g3
https://github.com/TheMuppets/proprietary_vendor_lge
these are all that I use

You must make device tree compatible with PA source.
https://github.com/AOSPA/android_vendor_pa/tree/nougat-caf/products
https://github.com/AOSPA/android_device_lge_d855
https://github.com/AOSPA/android_device_lge_g3-common
its old brach but get you idea
compare it to ex. "bacon" and make necessary changes
Im syncing PA right now, will try to build it

ppajdek said:
You must make device tree compatible with PA source.
https://github.com/AOSPA/android_vendor_pa/tree/nougat-caf/products
https://github.com/AOSPA/android_device_lge_d855
https://github.com/AOSPA/android_device_lge_g3-common
its old brach but get you idea
compare it to ex. "bacon" and make necessary changes
Im syncing PA right now, will try to build it
Click to expand...
Click to collapse
wielkie dzięki, spróbuję. można jakiś bliższy kontakt (telegram, whatsapp)?
(thank you so much, I am going to try it)

Trying to build Resurrection Remix 6.0 for A5 2017

Hey y'all!
I've seen that there aren't any lineageos 15.1 roms for a5 2017 out there so I decided I will build my own.
I followed the guide on rr's github page and I when I typed "breakfast a5y17lte" I got a big error that it cannot find the makefile. Also in device/samsung/a5y17lte there wasn't "vendorsetup.sh".
Please help.

Hello,
First, you can't build booting oreo aosp rom from actual sources.
Second, if you can't deal with something like that - leave building your own rom, or if you want to fight with that error, just use google and little common sense, nothing hard.
Good luck!

I'm glad someone out there is building custom roms for a5 2017. I looked for some the other day and couldn't find many.
Sent from my Samsung SM-A520W using XDA Labs

sheepkill15 said:
Hey y'all!
I've seen that there aren't any lineageos 15.1 roms for a5 2017 out there so I decided I will build my own.
I followed the guide on rr's github page and I when I typed "breakfast a5y17lte" I got a big error that it cannot find the makefile. Also in device/samsung/a5y17lte there wasn't "vendorsetup.sh".
Please help.
Click to expand...
Click to collapse
I got the same issue. I imported vendorsetup.sh from a device repo for another device, and adapted it to my own.
Code:
add_lunch_combo rr_a5y17lte-userdebug
This makes it show up in lunch combo but i get the same error as you,
Code:
Which would you like? [aosp_arm-eng] 16
build/core/product_config.mk:243: *** _nic.PRODUCTS.[[device/samsung/a5y17lte/rr.mk]]: "device/samsung/universal7880-common/common.mk" does not exist. Stop.
Device a5y17lte not found. Attempting to retrieve device repository from ResurrectionRemix-Devices Github (http://github.com/ResurrectionRemix-Devices).
Repository for a5y17lte not found in the ResurrectionRemix-Devices Github repository list.
If this is in error, you may need to manually add it to your .repo/local_manifests/roomservice.xml
build/core/product_config.mk:243: *** _nic.PRODUCTS.[[device/samsung/a5y17lte/rr.mk]]: "device/samsung/universal7880-common/common.mk" does not exist. Stop.
build/core/product_config.mk:243: *** _nic.PRODUCTS.[[device/samsung/a5y17lte/rr.mk]]: "device/samsung/universal7880-common/common.mk" does not exist. Stop.
** Don't have a product spec for: 'rr_a5y17lte'
** Do you have the right repo manifest?
I know this is very late too, but I'm just glad to see that I wasn't the only one having this issue.

YoMarshMellow said:
I got the same issue. I imported vendorsetup.sh from a device repo for another device, and adapted it to my own.
This makes it show up in lunch combo but i get the same error as you,
I know this is very late too, but I'm just glad to see that I wasn't the only one having this issue.
Click to expand...
Click to collapse
Actually, I managed to fix these and succesfully go along my merry way after a few days of google searches