[CM 12] Double tap 2 wake "disappear" fix - G3 Developer Discussion [Developers Only]

Currently dt2w doesn't work properly in CM 12, at least for some devices.
Because dt2w caused "black screen after call" issues, they patched it in this commit:
http://review.cyanogenmod.org/#/c/84385/
But it is not effective.
There are cases when this feature doesn't recognize that the call ended and leaves dt2w disabled.
Few examples would be: when you end call with power button; when callee hangs up the phone while you hold the phone near your face.
Basically it happens when call ends with proximity lock active.
It might even be the reason for another bug, "screen freeze after phone call", but I need more testing to be sure.
It is hard to tell why it happens, maybe it's because LG hardware/drivers, combination of both or something else. It seems G3 doesn't like when additional features "attached" to proximity sensor lock.
I even tried to report this bug, still nothing.
https://jira.cyanogenmod.org/browse/NIGHTLIES-948
So right now I'm trying to fix this, but still most important part yet to be done.
I reverted 84385 commit, but it brought me back to the state where double tap on screen during the call with proximity lock active recognized as dt2w. It just leaves the device with black screen after call. Kinda obvious.If I just turn off dt2w in settings it fixes the issue, but then I don't have this feature on my phone at all.
So far I tried different things to fix this issue:
- Modified /kernel/lge/g3/drivers/input/touchscreen/lge_touch_core.c, after that can't even finish the build.
- Tried to add feature from 84385 commit to /packages/apps/InCallUI/src/com/android/incallui/ProximitySensor.java, now incallui just crashes every time I try to make the call.
- GravityboxLP actually has the feature to disable dt2w while proximity sensor is covered, but for some reason it doesn't work while in phone call (only when screen just turned off).
- Same goes for https://github.com/SlimRoms/device_lge_g3-common/commit/5a8f935bdfc129f6fa3f906afa83f77c2c9084c1
- Various apps from PlayStore - nothing helps
What could actually work - if it was possible to find or implement thing like:
if (IsScreenBlank() && !in_phonecall) {
Log.d(this, "DT2W activated");
***.turnOnTapToWake();
}

Mate try contacting galaid he found a fix in his cm11 thread....

Related

[Q] CM7 - Display stays off during call

hello,
i have a problem with the sensor during call... when i move the phone away from my head, the display stays off, so that i can't stop the call (have to take out battery to stop call).
is there a workaround for that bug? i tried switching off "proximity sensor", but doesn't help... but also i want that feature
this is the only failure of cm7 that should be solved (in my opinion) to make it the best rom for defy
thanks in advance
SensorTest and plot app will see if the sensor is working
i've testet proximity sensor with an app called "phone tester"... this app shows, that proximitysensor recognizes, that i move near to the phone, but doesn't recognize if i move away from phone... i think this is an cm7-bug, because it works with original rom...
is there a workaround? is it possible to try another proximity-sensor-driver?
which is your cm7 version?
atm: nightly-build from 5.8.11, but it was also on rc1v2...
after a deep search in xda-forum i found a solution: i touched over the sensor with little pressure and now it works
but on stock i never had to touch it... it works always on stock and sometimes not on cm7 without touching the sensor... i am confused
You could try goto settings - Acessibility - "Power Button Ends Call".
Use power button to ends call which you don't need the display to turn on for ending a call.
thats a good idea! thank you!! ... btw: that option should be in "call settings" instead of accessibility... i think no one would expect it there
There's an option in Call Settings called "Always use proximity" which may be useful, and "also Keep screen awake".... both seem relevant to your problem. In Display settings there is also "In-accurate proximity" which I would suggest is enabled....
Sensor during call works on my CM7. For information, I've manual brightness, not auto... perhaps...

Device wake issues (power button ignoring first press)..

Hi,
I've had my M9 for a couple of weeks now, and slowly getting it to work how I want it to. One thing nagging me is this weird issue I have with waking the device from sleep.
I have tried to disable all the gesture/smart wake features (double tap the screen, etc). The issue I'm having seems to relate to the light and/or proximity sensor. It seems (and I haven't been able to find any info on this, online or on the phone) that there is a feature which will enable the device to wake up when being picked up or taken out of my pocket. This doesn't always work, but sometimes it does. When I pull my phone from my pocket, it will sometimes wake up. When I glide my finger over the front camera & light sensor, it will sometimes wake up. This is a minor annoyance, as I would like to only be able to wake my device by hitting the power button.
It gets really annoying when these 'gesture' wakes start to interfere with the power button wake. For example (and this is happening more often than not), when I pull my phone out of my pocket, the phone is off, then I hit the power button once, and the phone still doesn't wake. Hitting the power button a second time will wake the device. It seems to me that the smart waking is some how interfering with the manual waking.
Is anyone else seeing this behavior?
Any suggestions for a solution?
Thanks a lot for any help.
This is really odd considering the M9 doesn't support air gestures. Sorry, I have no solution, but is it possible you may have installed an app that may be causing this?
I would think two button push would be the normal, otherwise you could accidentally hit it once and turn the screen on. Do you have Ambient display and pocket detection all turned off ?
Gravity Screen in the play store gives you total control of all that stuff
That for the replies guys.
Clsa, there is no way to disable ambient display & pocket detect because those features do not exist on the M9 (at least... Not that I have found). That's what is bugging me.
I don't think the 2 button press is normal. I've never had to do it on previous phones.
Fernand - not sure if it is another app causing it. I think I have no extra apps installed compared to my last phone.
I just tried Gravity Screen, and it seems to just give me the ability to enable all the features I want to disable.
Any other suggestions?
[email protected] said:
That for the replies guys.
Clsa, there is no way to disable ambient display & pocket detect because those features do not exist on the M9 (at least... Not that I have found). That's what is bugging me.
I don't think the 2 button press is normal. I've never had to do it on previous phones.
Fernand - not sure if it is another app causing it. I think I have no extra apps installed compared to my last phone.
I just tried Gravity Screen, and it seems to just give me the ability to enable all the features I want to disable.
Any other suggestions?
Click to expand...
Click to collapse
Settings / Display & Gestures / Ambient display (Wake screen when device is picked up or notifications arrive)
Pocket Detection is part of some Rom Tweaks (insertcoin & viperOne if i remember right)
Hi again, that option is not available on my phone. Do you see it on your M9?
I don't have a custom ROM. Not rooted either.
[email protected] said:
Hi again, that option is not available on my phone. Do you see it on your M9?
I don't have a custom ROM. Not rooted either.
Click to expand...
Click to collapse
Yes I have it, but I'm on LeeDroid right now. He adds so much stuff i forget whats "custom" and whats stock
Got the same issue
The power button will ignore the first push while standing by for a long time. Thought it might be caused by apps like greentify?
Hi Ducati, is that a fact or is that just how you understand it? Seems strange that that would be intentional. But it definitely seems to be the case.
I do not have greenify installed either.
Do you get similar behaviour on your One?
After a bit more testing. I can confirm that there are some sort of air gestures on this device. I can wave my finger in front of the front light sensor/camera, and the device will wake.
This doesn't happen all the time, I am not always able to reproduce this. But right now, it is happening. Can anyone else reproduce this?
http://somevid.com/N1OnU8JS
I have the same issue on my M9. Glad I found this thread. Thought my power button was defective.
I can't activate any gestures by waving my hand.
I think it's happening mostly when waking from deep sleep.
I know it's an old thread, but I just installed CyanogenMod 12.1 and I guess my google-fu is rusty. I find that if I hit the power button in quick succession (double click) it turns off the phone. Anyone know how I can stop this?
By quick succession I mean multiple times within 20 seconds

Pocket mode is not working - who care?

Hi all
Several times here I had raised a question about not working mode "In pocket", but still no progress.
Just today I made a sprint and flashed several different ROMs (Havoc, crDroid, AEX, AICP, Viper, Colt, RR, and lot of others brands and versions a little bit earlier). Wiped, flashed rom + magisk, booted to new rom, set pocket mode on, rebooted (just for sure) and made a simple test:
locked phone by power button then closed a proximity sensor (left to the speaker on the top), then pressed the power button and always got the same result: regardless that proximity still closed (like in pocket), the lock screen is appearing and I can press playback buttons or unlock the phone. The only Syberia doesn't have this bug (but have some another, preventing me from using it).
Am I "the only one" who want to be sure that your smart will never awake in your pocket (when, for example, some notification will arrive) and start its own life, pressing all that will be available on lockscreen? So, common as a fundamental feature and ... it's not working for a very long time. What's ...? Maybe I missed some well-known trick on how to make it properly work?
comunity said:
Hi all
Several times here I had raised a question about not working mode "In pocket", but still no progress.
Just today I made a sprint and flashed several different ROMs. Wiped, flashed rom + magisk, booted to new rom, set pocket mode on, rebooted (just for sure) and made a simple test:
locked phone by power button then closed a proximity sensor (left to the speaker on the top), then pressed the power button and always got the same result: regardless that proximity still closed (like in pocket), the lock screen is appearing and I can press playback buttons or unlock the phone. The only Syberia doesn't have this bug (but have some another, preventing me from usin it).
Am I "the only one" who want to be sure that your smart will never awake in your pocket (when, for example, some notification will arrive) and start its own life, pressing all that will be available on lockscreen? So, common as a fundamental feature and ... it's not working for a very long time. What's ...? Maybe I missed some well-known trick on how to make it properly work?
Click to expand...
Click to collapse
Try Syberia 2.8 https://forum.xda-developers.com/lenovo-p2/development/rom-syberia-os-v2-8-t3958209
VladSor said:
Try Syberia 2.8 https://forum.xda-developers.com/lenovo-p2/development/rom-syberia-os-v2-8-t3958209
Click to expand...
Click to collapse
I tried... unfortunately, it works very "unstable" with LuckyPacther's Market and Google Pay, as for me ((
comunity said:
I tried... unfortunately, it works very "unstable" with LuckyPacther's Market and Google Pay, as for me ((
Click to expand...
Click to collapse
You are very similar to one of my countryman :laugh:
VladSor said:
You are very similar to one
Click to expand...
Click to collapse
I need a very small set of properly working stuff: Magisk with its MagiskHide, LuckyPatcher and its market, Google Pay working with the previous couple, Working Swift Installer and ... pocket mode. that's it
nevertheless, so easy for the testing feature is not working. it looks like QA is living somewhere in 4-th or 5-th dimension
In LOS16 Pocket mode is not working (
I assume, that this is a source for not working PM in all another custom ROM - a lot of them are using LOS16 as a base for their work. sadly...
May I ask moderator(s) move this question back to ROMs thread where I initially place it?
This is the only way (as it seems to me) to attract ROM builders at last fix this really annoying bug!
New ROMs' versions regularly appears, but ... who care? ((
Working "In pocket" mode. For any firmware!
Finally solved the problem forever.
You must use Automagic or any other automation tool that supports the following commands sequence:
- The screen turns on (trigger event)
- Immediately lock the device!
- Check the distance of the proximity sensor:
***- if <5cm - do nothing
***- if> 5cm - turn on the screen (smart not in your pocket)
Immediately locking is required because it takes 1-2 seconds to measure the distance and during this time you may press something on already switched on screen.

Themes / Apps / Mods [APP][11.0][12.1][13.0] AOSP DIALER with Proximity checkbox (call recorder incl) + macro

Since proximity sensor on F3 is fairly useless/non stable on calls I compiled the [A11/A12] AOSP dialer with proximity checkbox. Install via Magisk.
Set dialer as default phone app (reboot) and check proximity ON (so proximity doesn't work anymore...)
In call :
you can either use your powerbutton or double tap on statusbar to dim screen.
or you can use a small macro add-on I made - Call_AutoScreen_On-Off_(F3) - which auto dims screen when call is started and auto lights up the screen when call is ended. How to :
install MacroDroid
import the unzipped macro
give permissions where needed (reboot/don't forget to nuke proximity in dialer ofc).
thx @anuppoudel for testing as well
Added A12 AOSP Dialer
Thank you @raystef66 for providing such a useful solution, most needed
Since I got the F3, I've gotten used to just manually locking the screen before I put the phone to my ear. So, what advantage do I get from using your modified app?
Don't get me wrong, I appreciate your work! I'm just curious...
esszett said:
Since I got the F3, I've gotten used to just manually locking the screen before I put the phone to my ear. So, what advantage do I get from using your modified app?
Don't get me wrong, I appreciate your work! I'm just curious...
Click to expand...
Click to collapse
Automation instead of manually lock
raystef66 said:
Since proximity sensor on F3 is fairly useless/non stable on calls I compiled the AOSP dialer with proximity checkbox. Install via Magisk.
Set dialer as default phone app (reboot) and check proximity ON (so proximity doesn't work anymore...)
In call :
you can either use your powerbutton or double tap on statusbar to dim screen.
or you can use a small macro add-on I made - Call_AutoScreen_On-Off_(F3) - which auto dims screen when call is started and auto lights up the screen when call is ended. How to :
install MacroDroid
import the unzipped macro
give permissions where needed (reboot/don't forget to nuke proximity in dialer ofc).
thx @anuppoudel for testing as well
Click to expand...
Click to collapse
Thanks brother. U rock!
keyoke87 said:
Automation instead of manually lock
Click to expand...
Click to collapse
Ok, thanks...
1. The screen is locked with the app, but I have to manually dim the screen by pressing the power button? Hmm...
2. When the call starts I have to switch loudspeaker on and off again before I actually can hear the one who's calling (or the one I am calling resp.) over the earpiece (is there any solution for this bug out there? or has it even been solved and I'm still doing it out of habit? ).
Unfortunately, it seems that this mod would make the whole dumb workaround procedure even more frustrating (for me)
esszett said:
Ok, thanks...
1. The screen is locked with the app, but I have to manually dim the screen by pressing the power button? Hmm...
2. When the call starts I have to switch loudspeaker on and off again before I actually can hear the one who's calling (or the one I am calling resp.) over the earpiece (is there any solution for this bug out there? or has it even been solved and I'm still doing it out of habit? ).
Unfortunately, it seems that this mod would make the whole dumb workaround procedure even more frustrating (for me)
Click to expand...
Click to collapse
U can choose not to use. Dev is sharing his solution out of goodwill anyways
esszett said:
Ok, thanks...
1. The screen is locked with the app, but I have to manually dim the screen by pressing the power button? Hmm...
2. When the call starts I have to switch loudspeaker on and off again before I actually can hear the one who's calling (or the one I am calling resp.) over the earpiece (is there any solution for this bug out there? or has it even been solved and I'm still doing it out of habit? ).
Unfortunately, it seems that this mod would make the whole dumb workaround procedure even more frustrating (for me)
Click to expand...
Click to collapse
Point of this all is to nuke proximity sensor (more stability during calls) and let the macro do the job of auto dimming the screen when call gets active and waking it up when call's done. No more no less. So no more pressing the powerbutton or whatever.
Even with the macro running during call you can easily dt2w or press power button to wake screen. Dim it again by pressing the powerbutton again (or double tap statusbar). But how many times does that happen? Not much for me.
For you it does apparently because you have to press loudspeaker. Well you can as you did before on the other dialer you had. Only thing now is that proximity is disabled as well. So more stability.
In the past even with just pressing the power button I had wake-ups during calls. Proximity is unstable so therefore diabling it is the logic solution (for me).
As mentioned above, it's up to others to use it or not.
PS : in macro you can easily add some time to it before screen auto-dims so you have time enough to tap your loudspeaker. Or even add a speakerphone task. Up to you.
keyoke87 said:
U can choose not to use. Dev is sharing his solution out of goodwill anyways
Click to expand...
Click to collapse
Unfortunately, the problem with the proximity sensor is extremely unsatisfactory - a feature that always worked reliably since my first smartphone was mightily screwed up by Xiaomi. I guess everyone who makes several calls per day is annoyed by the behavior and is looking for solutions. Therefore, it is of course highly gratifying if among the annoyed users there are also a few developers who can program solutions.
My frustration with the proximity sensor was not meant to blame the dev for not bringing a solution that works for me - the criticism is solely for Xiaomi. As I said, I appreciate the developer's work! Therefore, sorry if my post came across with a bad mood... I'm glad that the workaround app offered by the dev helps many users
@raystef66
Thank you for your answer! Earlier I was still unsure, now I know: the loudspeaker on/off "game" isn't over on my device - I just tested it. For an outgoing call, I have to deactivate the loudspeaker only after the ring tone, otherwise the earpiece remains silent. Unfortunately, this ring tone sometimes starts after 1 second, sometimes after 5 seconds - and sometimes without waiting time the call starts immediately. So, I don't think it's possible to create a universal solution with a macro.
The thing that works for me, on the other hand, is that the phone stays locked until I unlock it (lucky me! ). Initially, this accidently wake-up also happened to me, because I came to the fingerprint sensor with the index finger or thumb - but here I have now also re-educated myself
Anyway, thanks for not resigning yourself to the status quo and continuing to look for solutions!
esszett said:
Unfortunately, the problem with the proximity sensor is extremely unsatisfactory - a feature that always worked reliably since my first smartphone was mightily screwed up by Xiaomi. I guess everyone who makes several calls per day is annoyed by the behavior and is looking for solutions. Therefore, it is of course highly gratifying if among the annoyed users there are also a few developers who can program solutions.
My frustration with the proximity sensor was not meant to blame the dev for not bringing a solution that works for me - the criticism is solely for Xiaomi. As I said, I appreciate the developer's work! Therefore, sorry if my post came across with a bad mood... I'm glad that the workaround app offered by the dev helps many users
@raystef66
Thank you for your answer! Earlier I was still unsure, now I know: the loudspeaker on/off "game" isn't over on my device - I just tested it. For an outgoing call, I have to deactivate the loudspeaker only after the ring tone, otherwise the earpiece remains silent. Unfortunately, this ring tone sometimes starts after 1 second, sometimes after 5 seconds - and sometimes without waiting time the call starts immediately. So, I don't think it's possible to create a universal solution with a macro.
The thing that works for me, on the other hand, is that the phone stays locked until I unlock it (lucky me! ). Initially, this accidently wake-up also happened to me, because I came to the fingerprint sensor with the index finger or thumb - but here I have now also re-educated myself
Anyway, thanks for not resigning yourself to the status quo and continuing to look for solutions!
Click to expand...
Click to collapse
no worries. i know that the proximity sensor on this phone is just trash. cheers!
On previous version call recording didn't work fully. Therefore made a second version which provides call recording as well
Alioth_AOSP_Dialer_Proximity_raystef66_v2
Apologies if this is off topic but this thread will likely attract the right eyes.. Dialing hasnt been my big problem yet..
How do you deal with pocket wake up ?? Face unlock (maybe tap to wake ??) the position of the fingerprint reader mean this thing is constantly awake and pin lock failing in my pockets.. Driving me crazy.
EDIT :::
Testing it (pixel experience plus) my phone never senses, in any orientation.. Others report some form of sensing.
Upright.. hand to phone.. hand over phone.. I am not getting anything.
It wakes on movement.. It wakes to attempt face unlock (I guess).. It wakes on screen touch,, it never overrides that despite there being an option to prevent accidental wake up (which has no noticeable effect). I dont see what combo of settings may be correct here.
Its currently flat out unusable.. Its a mobile phone which you cannot put in your pocket and which wakes as you carry it. People cant be just accepting this...
Both ZIP files added over Magisk? Or one with TWRP and one with Magisk?
Hi,
Thanks a lot for your useful app.
In android 12 I have a problem, app background color is a very awful green! Please check attachment, what is the problem?
Thanks!
beicuxhaven said:
Both ZIP files added over Magisk? Or one with TWRP and one with Magisk?
Click to expand...
Click to collapse
AOSP dialer is a module - Other is a macro - It's all in description.
Creative9170 said:
Hi,
Thanks a lot for your useful app.
In android 12 I have a problem, app background color is a very awful green! Please check attachment, what is the problem?
Thanks!
Click to expand...
Click to collapse
Because its 11.0. Not compiled for 12.
raystef66 said:
AOSP dialer is a module - Other is a macro - It's all in description.
Because its 11.0. Not compiled for 12.
Click to expand...
Click to collapse
Can you please compile it for A12 too? Because most of the A12 roms doesn't have call recorder now. But your aosp app works good on A12 but has some minor theme problems.
Thanks in advance
Creative9170 said:
Can you please compile it for A12 too? Because most of the A12 roms doesn't have call recorder now. But your aosp app works good on A12 but has some minor theme problems.
Thanks in advance
Click to expand...
Click to collapse
I second this. I like having call recording when I call automated robot calls than I don't need to pay a attention and if I miss something I can relisten to it without a problem or with headphones if it was to quiet. It also works to set people up but in my state it's illegal to record someone who doesn't know their being recorder. So you would just be getting yourself in trouble to.
Deleted
qestion where is the call recording saved location at ?
jefffrom said:
qestion where is the call recording saved location at ?
Click to expand...
Click to collapse
internal_music_call recordings

DOUBLE TAP TO WAKE ISSUE

I'm on Oreo (8.1) and everytime I put the phone in my pocket it unlocks on its own. It's very annoying because it ends up turning on torch, disabling wifi, dialing calls ecc.
I know that this phone has two screen types and apparently I got the one with DT2W enabled. I also know it got removed as a feature with Pie update, but I want to stay on Oreo.
Someone help me find a way to disable double tap to wake, please. Or at least give me a workaround. It's so frustrating.

Categories

Resources