Hi everybody!
I made a very simple module to expose auxiliary camera to @cstark27 Google Camera port.
As you may know his app is targeted to LGs wide cameras, but with this module you can use his app to take wonderful shots with our telephoto lens.
I originally posted here:
http://www.androidiani.com/forum/mo...ocamera-zoom-2x-ottico-con-google-camera.html
UPDATE V2:
Now is included fix for WhatsApp camera crashes when rotating phone.
https://forum.xda-developers.com/showpost.php?p=76506333&postcount=134
CUSTOM ROMS version:
This version enables Zoom support for Cstark27 "wide" versions WITHOUT breaking stock camera portrait mode.
I had to merge my fix with @ramesh1686 work.
https://forum.xda-developers.com/showpost.php?p=77984552&postcount=289
Known bugs:
Sometimes setting flash to "auto" makes dark photos. Set flash ON or OFF instead.
Istructions:
Install the module you need.
Reboot.
Install one of Cstark27 Google Camera "wide" or "tele" port.
Enjoy
Tested with Xiaomi mi a1 but it might work with other models too. (Dual cameras models of course)
A quick comparison:
http://www.androidiani.com/forum/mo...reo-porting-google-camera-31.html#post7995410
cool
Nice work! Hopefully this gets it in the hands of more capable devs! I look forward to seeing the progress.
PS: V3.3 is a couple versions old, but if it works the best no problem. Just though I'd mention that. The up to date thread can be found here.
Here's what's changed to access the secondary rear camera for Google Camera. The code is a little different on my newer versions because I added a toggle to fix LG G6 Lineage OS Camera ID, but the concept is the same and this is simpler to show.
iga.smali
Code:
:cond_0
:try_start_1
iget-object v0, p0, Liga;->b:Landroid/hardware/camera2/CameraManager;
invoke-virtual {v0}, Landroid/hardware/camera2/CameraManager;->getCameraIdList()[Ljava/lang/String;
move-result-object v2
invoke-static {v2}, Liya;->b(Ljava/lang/Object;)Ljava/lang/Object;
new-instance v3, Ljava/util/ArrayList;
array-length v0, v2
invoke-direct {v3, v0}, Ljava/util/ArrayList;-><init>(I)V
array-length v4, v2
const/4 v0, 0x1 [B]<------------ Start at Camera ID 1 (Front Camera)[/B]
:goto_0
if-ge v0, v4, :cond_1 [B]<------------ If greater or equal to 'v4' then skip the code below and continue[/B]
aget-object v5, v2, v0
new-instance v6, Ligc;
invoke-static {v5}, Ligc;->a(Ljava/lang/String;)Ljava/lang/Integer;
move-result-object v7
invoke-direct {v6, v5, v7}, Ligc;-><init>(Ljava/lang/String;Ljava/lang/Integer;)V
invoke-interface {v3, v6}, Ljava/util/List;->add(Ljava/lang/Object;)Z
add-int/lit8 v0, v0, 0x1 [B]<------------ Add 1 to counter to end at Camera ID 2 (Secondary rear)[/B]
goto :goto_0 [B]<------------ Loop back to goto_0 label[/B]
ecu.smali This edit fixes it so ZSL HDR+ works
Code:
const-string v4, "Acquired metadata from the first frame."
invoke-interface {v3, v4}, Licu;->b(Ljava/lang/String;)V
:try_end_0
.catch Ljava/util/concurrent/ExecutionException; {:try_start_0 .. :try_end_0} :catch_0
move-object/from16 v0, p0
iget-object v3, v0, Lecu;->e:Lgdq;
invoke-interface {v3}, Lgdq;->a()Ligc;
move-result-object v3
invoke-virtual {v3}, Ligc;->a()I
move-result v4
const v3, 0x2 [B]<----- add this line. Sets a variable to 2 (Camera ID 2)[/B]
if-ne v4, v3, :cond_f [B] <--------- add this line. If v4 is not equal to v3, skip over next line (this means if Camera ID is not 2, then keep the ID number and carry on)[/B]
const v4, 0x0 [B]<-------- add this line. Sets the variable to 0 (Camera ID 0). This means that if the Camera ID is set to 2 (Wide Angle app) then we need to make GCam think the ID is 0 for it to do ZSL HDR+ Processing.[/B]
:cond_f [B]<-------- add this line for the reference above[/B]
:try_start_1
move-object/from16 v0, p0
iget-object v3, v0, Lecu;->c:Licu;
const-string v5, "Starting HdrPlus#ZslShotCapture."
To get all cameras working in the app, we probably need to add a toggle that goes back to iga.smali and changes the start value to 0. Good luck!
@aer0zer0 this thread may be worth checking out for your phone/mods.
Great job. I flashed your module to try and the pictures in 2X are very nice!
Here the difference
Working great, thank you so much!
Yes, it's working great. I'm using latest version of @cstark27 Gcam. Hdr+ result for zoom camera is also great!
Thanks for your works!
Just one question, is there any possibility in the future that one moded Gcam can use both normal and zoom lens? Like it has a switch to choose between normal and zoom lens.
Now i have 3 camera version, miui cam, arnova's, and cstark's. I think that's too much
duniatri said:
Yes, it's working great. I'm using latest version of @cstark27 Gcam. Hdr+ result for zoom camera is also great!
Thanks for your works!
Just one question, is there any possibility in the future that one moded Gcam can use both normal and zoom lens? Like it has a switch to choose between normal and zoom lens.
Now i have 3 camera version, miui cam, arnova's, and cstark's. I think that's too much
Click to expand...
Click to collapse
Which one u using latest? Normal or wide cam ?
Rajeev said:
Which one u using latest? Normal or wide cam ?
Click to expand...
Click to collapse
Wide (zoom) one
duniatri said:
Wide (zoom) one
Click to expand...
Click to collapse
Thanks friend. Still settling force close is there right?
Rajeev said:
Thanks friend. Still settling force close is there right?
Click to expand...
Click to collapse
Nope. No force close on setting and video on last version. All good so far :good:
duniatri said:
Nope. No force close on setting and video on last version. All good so far :good:
Click to expand...
Click to collapse
Fantastic.. :good:
Rajeev said:
Thanks friend. Still settling force close is there right?
Click to expand...
Click to collapse
Version 3.6 wide angle camera getting fc on setting.
I am on stock feb beta
duniatri said:
Nope. No force close on setting and video on last version. All good so far :good:
Click to expand...
Click to collapse
That's Arnova's version I believe. The Wide (zoom) app should say Camera (Wide). My version Settings doesn't have the margins in the left and has a couple different options.
I'm going to assume that there's no Video related parameters available through the Camera2 API for the Zoom lens, so when you try to go to settings it crashes when it's trying to find that info. Not sure when I'll have time to dig into for you guys.
How does GCam 2x digital zoom on your regular lens compare to using GCam on the Zoom lens?
cstark27 said:
How does GCam 2x digital zoom on your regular lens compare to using GCam on the Zoom lens?
Click to expand...
Click to collapse
Night and day difference.
Finally no more ****ty Beauty mod.. Superb.. If we get working settings then can make some changes too...
@sipollo and @cstark27 thanks for everything
Rajeev said:
Finally no more ****ty Beauty mod.. Superb.. If we get working settings then can make some changes too...
@sipollo and @cstark27 thanks for everything
Click to expand...
Click to collapse
Which version you using? Pixel 2 Mod by Arnova and Tolyan?
joeyhuab said:
Which version you using? Pixel 2 Mod by Arnova and Tolyan?
Click to expand...
Click to collapse
Same version that available in OP bro. And my primary GCam is MGC Final v3.4. Using cstark version only for Telephoto... I think only cstark version support Telephoto. Am i correct?
Rajeev said:
Same version that available in OP bro. And my primary GCam is MGC Final v3.4. Using cstark version only for Telephoto... I think only cstark version support Telephoto. Am i correct?
Click to expand...
Click to collapse
Thanks! Will stock to Tolyan's version for primary GCam. Will stick to v3.3 for Camera (Wide) but hopefully someone updates the app for v3.6 support.
cstark27 said:
That's Arnova's version I believe. The Wide (zoom) app should say Camera (Wide). My version Settings doesn't have the margins in the left and has a couple different options.
I'm going to assume that there's no Video related parameters available through the Camera2 API for the Zoom lens, so when you try to go to settings it crashes when it's trying to find that info. Not sure when I'll have time to dig into for you guys.
How does GCam 2x digital zoom on your regular lens compare to using GCam on the Zoom lens?
Click to expand...
Click to collapse
It's your cam. I can go to settings, open video, and even see 'about' to see your cam version. See my screenshot. Ohya, video recording also works :good:
duniatri said:
It's your cam. I can go to settings, open video, and even see 'about' to see your cam version. See my screenshot. Ohya, video recording also works :good:
Click to expand...
Click to collapse
Which ROM are you using and what other modules do you have installed? I installed the module and APK linked in the OP but the Camera (Wide) crashes in Pixel Experience ROM.
Related
Is there any WORKING camera mod for the HTC M8 ?
HTC camera has lots of nice settings and allows a great level of control, but what really piss me off is the level of compression in the photos.
I've tried Jishnu's camera mod V4, installed from twrp, but it doesn't seem to work because videos are still recorded at 20mbps.
https://play.google.com/store/apps/details?id=com.caddish_hedgehog.hedgecam2
Says it supports Camera2 API, all manual adjustments, and RAW support. For those with P2, can y'all check if it supports HDR+/Enhanced? Or is Google's cam app still the only one?
Burninh2o said:
https://play.google.com/store/apps/details?id=com.caddish_hedgehog.hedgecam2
Says it supports Camera2 API, all manual adjustments, and RAW support. For those with P2, can y'all check if it supports HDR+/Enhanced? Or is Google's cam app still the only one?
Click to expand...
Click to collapse
Tried it for a short while. HDR option is there but Google camera is leaps n bounds ahead
Sent from my Pixel 2 XL using Tapatalk
This thread is made to give feedback about @Arnova8G2's Google camera versions
To report a bug:
1. Write the bug you experienced (if the bug is already known, please don't post the same bug again)
2. INCLUDE LOGS OR YOUR POST WILL BE IGNORED. If you don't know how to get logs, go to here https://www.celsoazevedo.com/files/android/how-to-save-logcat/
3. Mention @Arnova8G2 in your post
All Gcam ports by Arnova8G2 can be found here.
Mods and fixes:
60FPS (only 1080p and lower) magisk module from 4PDA shared by @Rajce
Installation steps: Just flash in magisk (DO NOT FLASH THIS IN TWRP)
Download
Tested on 8.1 ROMs, saneklic gcam, Pixel2ModV8 by Arnova8G2
Reserved 2
@Arnova8G2 When taking a photo in portrait mode using front camera the app either does nothing or won't process the picture. Running AEX 7.1.2 with pixel 2 mod v7 beta 9
Stampyron said:
@Arnova8G2 When taking a photo in portrait mode using front camera the app either does nothing or won't process the picture. Running AEX 7.1.2 with pixel 2 mod v7 beta 9
Click to expand...
Click to collapse
HDR+ doesn't work as well. Or is it just me ?
stole38 said:
HDR+ doesn't work as well. Or is it just me ?
Click to expand...
Click to collapse
Looks like my front camera doesn't work at all. When I put it to hdr+ enhanced the app just crashed. When hdr+ is on either the app doesn't process the photo or I get a completely green picture. When hdr+ is off I just get a green picture. Log attached
@Arnova8G2
I'm sending this MatLog using the apk version "Arnova's v7beta9".
I just activated HDR + Improved it does not work on the front camera, it closes the application or sometimes it renders the image without loading the bar, I can not portrait mode on the front with redmi 5 plus vince.
LogCat link up on Google drive: https://drive.google.com/open?id=0B7VEAN5tQuSnMlhGUjNCOXZxMzFRZnMycS1FZU5qYzh1Q3cw
Perfectly working on rom MIUI.it.
Inviato dal mio Redmi 5 Plus utilizzando Tapatalk
masterdex said:
Perfectly working on rom MIUI.it.
Inviato dal mio Redmi 5 Plus utilizzando Tapatalk
Click to expand...
Click to collapse
Is slowmotion working? I don't think so
I'll started to try camera mods, this looks great for functionally on my phone, but have some glitches on my phone.
Phone: Redmi 5 Plus Global
Camera sensor: Sony IMX 486
Front sensor: OV5675
Rom: Xiaomi.eu latest
Camera2API enabled
Finally the burst mode working "good", this mod will be super when is done.
Rear camera: So the camera screen is freezing for long seconds, when moving a bit more, shaking the phone. Looks a bit the exposition and the light couse this.
After this need to wait some seconds 10-15 and the live preview and the cam working again.
I thinking at the first time and off the auto rotation setting, because a lot of times only need to rotate the phone 90 degree and crashed. But this not solved the problem
And a lot of times get FC.
Front camera: make a green glitch picture (not a real picture, looks when the photo is damaged and overall a green mishmash)
Here's the logcat.
Steve1207 said:
I'll started to try camera mods, this looks great for functionally on my phone, but have some glitches on my phone.
Phone: Redmi 5 Plus Global
Camera sensor: Sony IMX 486
Front sensor: OV5675
Rom: Xiaomi.eu latest
Camera2API enabled
Finally the burst mode working "good", this mod will be super when is done.
Rear camera: So the camera screen is freezing for long seconds, when moving a bit more, shaking the phone. Looks a bit the exposition and the light couse this.
After this need to wait some seconds 10-15 and the live preview and the cam working again.
I thinking at the first time and off the auto rotation setting, because a lot of times only need to rotate the phone 90 degree and crashed. But this not solved the problem
And a lot of times get FC.
Front camera: make a green glitch picture (not a real picture, looks when the photo is damaged and overall a green mishmash)
Here's the logcat.
Click to expand...
Click to collapse
I've actually never got any FCs on my phone running AEX, maybe because my camera sensor is omnivision
Stampyron said:
I've actually never got any FCs on my phone running AEX, maybe because my camera sensor is omnivision
Click to expand...
Click to collapse
If working great I think the problem is the MIUI.
Steve1207 said:
If working great I think the problem is the MIUI.
Click to expand...
Click to collapse
I still face the issues with my front camera though
always force closed after take front cam photo
Immediate crash, didnt flash the camera2 api mod tho
DarthKeizer said:
Immediate crash, didnt flash the camera2 api mod tho
Click to expand...
Click to collapse
What ROM are you using?
Can anybody test this build and report back, I'm currently using RR treble so my camera isn't working (yet):silly:
2018/04/14 – GoogleCamera-Pixel3Mod
ChangeLog :
Based GoogleCamera-5.2.022.191678196
Fix Motion photo 4:3
Add 30/60 fps for 4K
Add Auto-exposure mode by B-S-G
And some improvement
Version without any config, just to enjoy.
GoogleCamera-Pixel3Mod-Arnova8G2-V1.apk
Click to expand...
Click to collapse
Stampyron said:
Can anybody test this build and report back, I'm currently using RR treble so my camera isn't working (yet):silly:
Click to expand...
Click to collapse
Force Close on xiaomi.eu latest rom, camera 2 api enabled.
Steve1207 said:
Force Close on xiaomi.eu latest rom, camera 2 api enabled.
Click to expand...
Click to collapse
Same.
Steve1207 said:
Force Close on xiaomi.eu latest rom, camera 2 api enabled.
Click to expand...
Click to collapse
n0_xQuZe said:
Same.
Click to expand...
Click to collapse
My bad, looks like this camera is only compatible with Android Oreo and above
I didn't find a specific thread for this port for A1, so I open a new one.
Whether moderators find this a clone, please delete/fix it as they please.
I am using GCam port by Arnova8G2, Pixel3mod v1 and it works great in every aspect (slow motion included), except front camera has a magenta/pink hue in low light when HDR+ is enabled, even if the specific correction option is active.
Anyone having this issue?
by far best version
DavideLosito said:
I didn't find a specific thread for this port for A1, so I open a new one.
Whether moderators find this a clone, please delete/fix it as they please.
I am using GCam port by Arnova8G2, Pixel3mod v1 and it works great in every aspect (slow motion included), except front camera has a magenta/pink hue in low light when HDR+ is enabled, even if the specific correction option is active.
Anyone having this issue?
Click to expand...
Click to collapse
this is by far best version.
https://www.celsoazevedo.com/files/android/google-camera/f/changelog156/
AndroGeek911 said:
this is by far best version.
https://www.celsoazevedo.com/files/android/google-camera/f/changelog156/
Click to expand...
Click to collapse
Not in my experience.
Image processing quality is lower.
DavideLosito said:
I didn't find a specific thread for this port for A1, so I open a new one.
Whether moderators find this a clone, please delete/fix it as they please.
I am using GCam port by Arnova8G2, Pixel3mod v1 and it works great in every aspect (slow motion included), except front camera has a magenta/pink hue in low light when HDR+ is enabled, even if the specific correction option is active.
Anyone having this issue?
Click to expand...
Click to collapse
There is a feedback thread for Arnova ports. Read the OP.
https://forum.xda-developers.com/mi-a1/themes/request-google-camera-hdr-mi-a1-t3684325/page15
DavideLosito said:
I didn't find a specific thread for this port for A1, so I open a new one.
Whether moderators find this a clone, please delete/fix it as they please.
I am using GCam port by Arnova8G2, Pixel3mod v1 and it works great in every aspect (slow motion included), except front camera has a magenta/pink hue in low light when HDR+ is enabled, even if the specific correction option is active.
Anyone having this issue?
Click to expand...
Click to collapse
You can do this in download the Camera2 Test app and share the device_info file.
this could help me understand the color use for the front camera.
Arnova8G2 said:
You can do this in download the Camera2 Test app and share the device_info file.
this could help me understand the color use for the front camera.
Click to expand...
Click to collapse
I hope these are the correct informations.
Sorry for being noob.
https://drive.google.com/open?id=1atGcjKhrmuKGIPrwCclmUUaSbtI3IgAH
For the OP: Use latest releases and you won't have any issues.
BTW, Just tested latest Arnova's releases (test apks, both Pixel2 and Pixel3) and I think we finally have AIO camera for Mi A1 that produces great shots in all conditions. Also all the options work flawlessly including the slow motion! Now Slow-mo can work without opening stock camera first and then Google Camera. Personally I like more Pixel2Mod, but both are performing great.
For telephoto lens on completely stock phone we still need to use Stock camera, right? Since Gcam doesn't support it? Or I'm mistaken?
marko.dnb said:
For the OP: Use latest releases and you won't have any issues.
BTW, Just tested latest Arnova's releases (test apks, both Pixel2 and Pixel3) and I think we finally have AIO camera for Mi A1 that produces great shots in all conditions. Also all the options work flawlessly including the slow motion! Now Slow-mo can work without opening stock camera first and then Google Camera. Personally I like more Pixel2Mod, but both are performing great.
For telephoto lens on completely stock phone we still need to use Stock camera, right? Since Gcam doesn't support it? Or I'm mistaken?
Click to expand...
Click to collapse
Agreed about the recent Arnova's.
Theres a thread about a module for the telephoto cam. Haven't tried it myself.
https://forum.xda-developers.com/mi-a1/themes/magisk-google-camera-telephoto-lens-t3767531
I have this issue too, somehow I missed it till now. It occurs on HDR+ off at every photo and HDR+ when taking multiple photos fast. On HDR+ enhanced everything is working fine, but it takes more time to process photos. We are talking about indoor photos with average lightning. Outside on the sun everything works perfect.
DavideLosito said:
I didn't find a specific thread for this port for A1, so I open a new one.
Whether moderators find this a clone, please delete/fix it as they please.
I am using GCam port by Arnova8G2, Pixel3mod v1 and it works great in every aspect (slow motion included), except front camera has a magenta/pink hue in low light when HDR+ is enabled, even if the specific correction option is active.
Anyone having this issue?
Click to expand...
Click to collapse
I used to have that bug in older versions. Also the opposite one (greenish tint). Sadly, there is no advanced setting to solve it like other devs have implemented.
My favourite version is Serjo87's. Dot issue is present but a lot softer than arnova/bsg/everyoneelse versions. Advanced settings lets adjust colors and noise levels, and also makes brighter pics in poor light conditions than arnova (tested with the older arnova's versions, not that last one).
I hope someday we can have the definitive mod with all the best thing of each dev, compatible with our phone. Meanwhile, I have 4 camera apps installed
barrack1 said:
Agreed about the recent Arnova's.
Theres a thread about a module for the telephoto cam. Haven't tried it myself.
https://forum.xda-developers.com/mi-a1/themes/magisk-google-camera-telephoto-lens-t3767531
Click to expand...
Click to collapse
Im using it. Mod works PERFECT with cstark's and sipollo's apks. It REALLY uses the second sensor, not faking by zoom (try by coverng one at a time). Only ownside is that using HDR in high bright conditions makes the app crash. If you can live with activating and de-activating HDR depending on light conditions, it gets the job done. The quality that you get in poor light scenes is day and night compared to stock telephoto. Give it a try!!
AndroGeek911 said:
this is by far best version.
https://www.celsoazevedo.com/files/android/google-camera/f/changelog156/
Click to expand...
Click to collapse
This doesn't support ZSL
[Correction]
It supports ZSL..But if i select 6p then no ZSL.
Google Camera v7.0.009 - v13 - final version made by Bulkin043 aka InnocentParrot
https://drive.google.com/file/d/1kaGLg1n9eoHp4Br8BO4z5Wit3Y5PWIl4
changelog
A small update that fixes some flaws in the modification. Be sure to clear the data from the application!
Good luck with your photos!
This is the final build 7.0.009.
I will be sharing here the mod, made by Buikin043 aka InnocentParrot
does this need root?
eraycetin said:
does this need root?
Click to expand...
Click to collapse
No, you should be able to install it as a normal application.
any contraindication?
works on all versions of RN7 ?
I'll try asap
Google Camera v7.0.009 - v3
https://drive.google.com/file/d/1frFz_CcUQFNjnpb1-Gs7yKUbEG2uh5Fh
its a beta version, expect something to fail or not working properly
new update
Google Camera v7.0.009 - v4
https://drive.google.com/file/d/1D2BafwP8456rnlR5j7m0EX-M9hkSIuqL
so far no portrait mode but everything else are working
Hello, first ... The gcam versions are great and much better than the stock cam because much more details in the pic. Big thanks to the developer.
.
I tested nearly all..from 6.1 to now 7, from all modders
.
But i only see a different in the awb and sharpness up to the lib.
So ..for me.. there is no great different. 7. looks for me like the 6.3 versions (picquality)
.
I miss really a pro mode with manual iso and shuttertime.
.
That together works for me in no versions from all modders. Is there a chance to get it. Like in the stockcam?
.
What you think?
.
Best greetings
Google Camera v7.0.009 - v5
https://drive.google.com/file/d/1zpzU6AOPSrJVGjYdRmXLVASdqIKNEtCd
new update
Google Camera v7.0.009 - v7
https://drive.google.com/file/d/1GUvTyq1Yx2kbNxRXHIRU6PQ45bCo0bi_
Does this version have -rumored- astrophotography mode?
have changelog?
Slow motion bug and 60fps video
Enviado desde mi Redmi Note 7 mediante Tapatalk
Alifirdaus said:
have changelog?
Click to expand...
Click to collapse
v7
• Completely repaired the front camera on the Redmi Note 5 Pro with HDR +. Thanks for testing the wildpisos fix.
• Fixed a green fill on the front camera on Redmi Note 5 Pro.
• Fixed spots on the front camera on the Redmi Note 7 device.
• Fixed toggle disabling the "Slowdown" icon. Thanks for finding the error Stranger_47.
front camera makes skin colour more dark than natural, can you fix it pls ??
ifat aony said:
front camera makes skin colour more dark than natural, can you fix it pls ??
Click to expand...
Click to collapse
change the hdr setting
Portrait mode available or not?
Avik Sarkar said:
Portrait mode available or not?
Click to expand...
Click to collapse
nope
guys dont forget its a beta