Hi,
this is a topic I want to start in order to help the development of more intelligent brightness control for Galaxy S (probably regional variants of it will benefit as well).
It began with my PM to some of kernel DEVs that I've noticed brownish color instead of black on ONE brightness setting. My idea was to omit that one brightness level.
Overnight, I already got two responses. One that it should be no problem and one that the link I sent might lead to fixing the problem I mentioned as well (color correction).
The other, connected to brightness topic, thing I've noticed is that auto control of it is retarded. First, it's too jumpy without any reason (like let's say change of outside brightness) and second it likes to set level that burn the eyeballs. I've never had such problem on my CM Hero.
Here's my original PM:
embrion said:
Hi,
I'm PMing you as the most popular kernels coders.
Long story short: SAMOLED screens like to make black or similar colors brownish at low brightness. I've (and not only me) noticed that there's a step just about min. when it starts to be brown and a next step after that it magically stops. The idea is to omit this step at all or just in auto brightness table. I believe It's doable by using those methods.
The original story begins here from the first half of #522 post
Like I've wrote there, this problem exists in all kernels and all color temperature variants of them + stock one.
If you're interested, please respond me. If not, also respond as I'd like to know if I can count on anything.
Thanks
Click to expand...
Click to collapse
Some links that might help:
[SOLUTION] Fix for minimum screen brightness! [10/13 - adjustable]
Kernel makers, please add the ability to adjust auto brightness.
[APP] Different auto-brightness
Gizmodo - Why iPhone 4 and Android Brightness Controls Are Effectively Useless
My random thoughts:
One option would be fooling the sensor that it is less bright than it is
Another, more proper I believe, it to modify some brightness tables to leave extreme brightness levels to extreme outside light situations. This one would also help skipping this "brown" brightness level as like I said, it looks to be only one level
Color correction MIGHT fix "brown" problem too, but I'm not sure as COLD and WARM kernel variants didn't changed this brown problem (unless colors are optimized only for some of the levels like I've read at VOODOO site)
CM 6 already has such brightness level options in Settings-> CM Settings - > User interface -> Automatic backlight -> Use custom(just checked on my Hero) so probably lot of code can be reused (as I believe there is CM for Galaxy S)
Kernel DEVs, fell free to hijack this thread. It is to help your cooperation (unless each one of you prefer to solve problems on they own ) Btw. don't be offended if I didn't included you in the DEVs list I've sent my PM. It was late and I PMed only those I've noticed that they kernels I've used. All of you are more than welcomed.
Other, please don't post "I cannot see any brown", and those one that can see it, please stop posting about info after first 5 people do
I'm so happy to read this threat. I had posted questions about display and auto brightness a couple of months ago in the questions section but never received any credible responses.
My problem is that when I turn auto brightness on, not only does my display get exceptionally dark, but it becomes very noticeable that e.g. grey turns more brownish. Comparing my display to yet another Galaxy S confirmed my suspicions that this is not they way the display is supposed operate, i.e. compared to mine the other Galaxy stayed a lot brighter in equal lighting conditions and the grey remained grey (instead of brownish-grey like mine). I compared the grey tones of the numeric buttons in the stock Dialer APP to conclude this.
I suspectED the light sensor might be defective, but I have run the test menu on a couple of Galaxies (*#0589#) and the units always display the same values when put next to mine.
You might see why this is bugging me so much, it seems my galaxy's display is not using less battery even though I get less brightness than the others on auto brightness. Unless I manually bump up the brightness to full the colors on my screen look dull (grey turns Brownish, and over all it looks not as alive) as compared to other units. Simply bumping the brightness up is of course not an option, this drain the battery like crazy.
EDIT: I too have tried the various Kernels, hardcore warm and cold, voodoo w/ color fix sadly all to no avail
EDIT2: @embrion The above all doesn't explain why our phones have this problem, but the far majority of Galaxy S phones doesn't. Of course I cannot statistically back this up, but I have not physically seen any other device that gets brown on autobrightness like ours. Any Ideas?
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
embrion said:
Do you say your friend's Galaxy S doesn't turn brownish or it does but gives higher brightness than your device in same lighting conditions?
Click to expand...
Click to collapse
It does not turn brown and appears much brighter in equal lighting w/ auto brightness ON. I edited my post above, please read again if it was unclear before. Thank you!!
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
embrion said:
You should check it at manual brightness at level set few steps higher than min. I'd like to separate brownish display problem at one brightness level from inproper light sensor measure
Click to expand...
Click to collapse
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
(Auto)brightness corrections
Original Auto Brightness level is too high & sluggish.
It 's need to fix like a voodoo Brightness level fix (2.1 only).
schiphol said:
Like I said, the light sensor does not give an improper measure, the readings in *#0589# menu are equal across the devices (including mine). The brownish color tones do, to some degree, disappear if the brightness bar is set two ticks to the right of minimum.
Click to expand...
Click to collapse
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
embrion said:
Yes, mine too. Second step from min. setting. I'll ask guys at my local forums to get some statistics. If your friend doesn't have such problem at the same color/theme than it must be display fault
Click to expand...
Click to collapse
Which CSC code do you have? I mine was originally XEN (Netherlands). The units I tested that did not have the problem were all DBT (german Sim free). Just asked my brother and he says his phone also gets brownish (also XEN). Have to check product codes later, will update then.
Mine is XEE (Orange, Poland)
Supercurio did some tinkering with those settings:
https://github.com/project-voodoo/l...a2/Kernel/drivers/video/samsung/s3cfb_mdnie.c
I suspect this is the file we need to modify;
Code:
mDNIe_data_type mDNIe_UI[]=
{
#ifdef CONFIG_VOODOO_MDNIE
// Voodoo color: optimized UI mode
// reduce the sharpness filter radius to make it much closer
// to the real fuzzyness introduced by the SAMOLED Pentile pattern
// color saturation boost on everything is also disabled because
// it causes harm on stock settings (exaggerated colors)
0x0084, 0x0040,
0x0090, 0x0000,
0x0094, 0x0FFF,
0x0098, 0x005C,
0x009C, 0x0613,
0x00AC, 0x0000,
0x00B4, 0x0A00,
0x00C0, 0x0400,
0x00C4, 0x7200,
0x00C8, 0x008D,
0x00D0, 0x00C0,
END_SEQ, 0x0000,
Any thoughts and datasheet quotations on this? Because seriously I see just random numbers in this.
Some interesting code begins around line 315, but seriously I'm clueless
Another interesting file:
https://github.com/project-voodoo/l...2/Kernel/drivers/video/samsung/s3cfb_tl2796.c
My screen has brownish/reddish deep grays on brightness settings under 16-17%. However when I set it over 17% and use screen filter app deep grays are NOT brownish/reddish, this means there is definitely something with lower brightness settings.
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
embrion said:
Xan, check out the link I've posted in the first post. He gives sources that might be helpful
And the problem appears only at 2nd step of brightness (counted from zero brightness)
Click to expand...
Click to collapse
@embrion so did you pm Supercurio? What did he say? It's too bad this color/sharpness fixing will probably be put on a back burner what with Gingerbread and CM7 development. D*RN IT! I tried an app in the market that is more precise than the built-in slider. Try it out Adjbrightness (free). I punched in all values possible between 2-255. The tipping point (where the browness is gone) lies at when you go from 34 to 35. Is this the same for everyone suffering from this problem. Please remove all apps like e.g. 'screen filter' before you try!
For me crucial step is going from
/ # echo 53 > /sys/devices/platform/s3cfb/spi_gpio.3/spi3.0/backlight/s5p_bl/brightness
to 54, however I'm running trasig's voodoo.
While 54 and over looks ok, lower values are... reddish/pinkish.
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
embrion said:
@schiphol: yes I did but no response. In dark colored Gingerbread era, this problem will be become more and more evident.
@xan: dzieki I'll flash latest Darky as it is based on trasig's voodoo and try your fix.
--edited--
Supercurio just responded me, I'll let you know about results
Click to expand...
Click to collapse
No fix there, just a different behaviour...
Would like to see this in next voodoo, might even write some simple user interface for this.
I have an idea but its not quite clear yet, however if this patch will let most users 'calibrate' their screens.. I think I'll give simple GUI a shot.
@embrion
Could you perhaps upload the screenshots you talked about in R64's thread so I can replicate. Because of different kernels and settings I want to try and establish beyond a doubt that the problem we're having is of the same nature and root cause. Thanks
This wont be visible on screenshots. You need to make a photo, problably with DSLR and know how to do it
I'll try it today and let you know
According to Supercurio, this is Samsung's color profile deviation, not SAMOLED fault itself.
Anything software broken can be software fixed
@schiphol, xan: yes, it won't be noticed at screenshots, I've already compared R64's black notification bar screenshots and my brown ones. Color picker showed a little difference in color (R:24, G:24, B:24 or something VS RGB: 0, 0, 0 - true black). Such difference should'n be visible and is not visible from software screenshot point of view but Samsung color profile makes 24,24,24 brown IN REAL LIFE while 0,0,0 is still black. I repeat, they're both black at screenshots no matter which brightness level is set, but only 0,0,0 black doesn't look like brown when viewed by bare human eye. Samsung profile at this brightness treats 24,24,24 as brown while it should as black.
--edited--
You're right, Xan. It's just another, ( but 1337 ) method of changing the brightness. I thought there's a plaintext table with levels accessible to change by hand
Hi Ok I have kept the brightness at 2 clicks to the right from minimum to stop grey from looking grey-brown all through today. Now my display accounts for 95% of the battery usage, it has never been this high before. The battery is at 25% whilst I only used the display for 44 minutes.
Thats ridiculous battery drainage and should be taken into careful consideration when a fix is developed for this issue. Are you guys having a similar experience??
Hi all. I've seen this feature in the first note and now I see it again.
Adjusting tone save the energy saver based on image analysis
Is this option really make a difference?
h t t p://imageshack.us/f/202/20130221221021.png
No 10 posts so sorry for link
I always have it set to off. I had it on but never noticed any difference. My guess is that if you are looking at a very colorful image, prolly the screen will lighten more up or over-saturate the colors to look nicer. Maybe even the brightness who knows.
According to a cnet article:
" There's another adjustment on the Note 2 to that significantly affects picture quality. Samsung applied the cryptic moniker "Auto adjust screen tone" (AAST) to a check box at the bottom of the Display menu. Uncheck it and the phone's full light output capabilities are unshackled, nearly doubling its contrast ratio and improving its ability to compete with ambient light. Turning off AAST also improves color accuracy slightly. "
Seems like changes the colour tone of brighter colours to reduce their brightness.
I keep it on since I like milder screens.
If you prefer low brightness and want to save power , keep it on.
If you find yourself using high brightness often, turn it off.
Sent from my GT-N7100
HypoDest said:
According to a cnet article:
" There's another adjustment on the Note 2 to that significantly affects picture quality. Samsung applied the cryptic moniker "Auto adjust screen tone" (AAST) to a check box at the bottom of the Display menu. Uncheck it and the phone's full light output capabilities are unshackled, nearly doubling its contrast ratio and improving its ability to compete with ambient light. Turning off AAST also improves color accuracy slightly. "
Seems like changes the colour tone of brighter colours to reduce their brightness.
I keep it on since I like milder screens.
If you prefer low brightness and want to save power , keep it on.
If you find yourself using high brightness often, turn it off.
Sent from my GT-N7100
Click to expand...
Click to collapse
Thanks you for info.
I know there are some programs that can alter display color temperature depending on time of day and global user position on Earth.
What I'm looking for is a program that can do the same based on light sensor data, I mean that outside in the sun, display have a high color temp, let's say 6500-7200 C and when I get into a dark room the display will not only decrease brightness like it always does but also change color temp to for example 3400 C. Blue light filtering like that is nice not only late at night before sleep but also while spending a lot of time indoors even during day.
So my question is - did anyone ever seen an app that can do that?
Interesting idea. I haven't heard of an app that can do this, but I'm sure with some Googling you'd be able to find out for sure.
I had a quick Google myself and it turns out that some high-end Samsung phones do this by default. Their light sensors detect Red, Blue and Green and change the screens colour to reflect your surroundings. Its called Adapt Display.
I'm not sure the light sensor on all smartphones can detect colour range tho, I think most are only capable of detecting luminance. If that's the case I'm sure someone could create an app that reads colour data from the camera when the light changes and could apply that to the screen hue to more accurately reflect the colour temperature of your environment, but I doubt it would be that accurate...
Yes, they can adapt but you can't make them change color with light intensity. This is actually what inspired me to look for better functionality
Does anyone know how to turn off the s20's adaptive display feature? (I'm not asking about adaptive brightness.) I'm on a US snapdragon, unlocked, regular S20. Thanks!
I am referring to:
"Samsung's adaptive super AMOLED screen optimizes the color range, saturation, and sharpness of the picture depending on what you're watching or doing."
https://www.samsung.com/us/support/answer/ANS00063051/
The vivid/natural, white balance, and advanced RGB settings mentioned in that link do NOT seem to impact the adaptive display feature. (And in fact, white balance and RGB settings don't seem to do anything at all... If anyone has thoughts about why THAT is, or how to make them actually have an effect, I'm interested.)
I have tried turning off dark mode completely, turning off the video enhancer, and turning off the dark mode on wallpaper, but the problem persists and impacts things like apps and pages in Chrome - basically everything.
If I look at my task switcher, app screens will often look the way I want them to in the preview, but when I click on one, after about a second the display adjusts and changes the image to something brighter, whiter, and less what I want. This is true whether adaptive brightness is on OR off.
I'm trying to use a screen filter to manually set the screen to the settings I need, and it feels like the screen is fighting the filter and countering it, and I think this business with the adaptive display optimizing color and saturation could be the problem. Or if you have other ideas for the source of the problem, I want to hear them.
Any help is appreciated!
Erre én is k
dovesong said:
Does anyone know how to turn off the s20's adaptive display feature? (I'm not asking about adaptive brightness.) I'm on a US snapdragon, unlocked, regular S20. Thanks!
I am referring to:
"Samsung's adaptive super AMOLED screen optimizes the color range, saturation, and sharpness of the picture depending on what you're watching or doing."
https://www.samsung.com/us/support/answer/ANS00063051/
The vivid/natural, white balance, and advanced RGB settings mentioned in that link do NOT seem to impact the adaptive display feature. (And in fact, white balance and RGB settings don't seem to do anything at all... If anyone has thoughts about why THAT is, or how to make them actually have an effect, I'm interested.)
I have tried turning off dark mode completely, turning off the video enhancer, and turning off the dark mode on wallpaper, but the problem persists and impacts things like apps and pages in Chrome - basically everything.
If I look at my task switcher, app screens will often look the way I want them to in the preview, but when I click on one, after about a second the display adjusts and changes the image to something brighter, whiter, and less what I want. This is true whether adaptive brightness is on OR off.
I'm trying to use a screen filter to manually set the screen to the settings I need, and it feels like the screen is fighting the filter and countering it, and I think this business with the adaptive display optimizing color and saturation could be the problem. Or if you have other ideas for the source of the problem, I want to hear them.
Any help is appreciated!
Click to expand...
Click to collapse
they removed the option to close adaptive display since Note 9 starting from s10 it is always on and can't be disabled
They removed the option to close adaptive display since Note 9 starting from s10 it is always on and can't be disabled
It was something like attached picture on Note 9
Ah hah! I think I figured out a solution to my problem (which was that the whites were too blue and bright and vivid as compared to everything else on the screen, no matter what settings I used on Twilight or another screen filtering app). For anyone who comes after me with a similar issue: the native blue light filter doesn't JUST turn on/off - it has an opacity setting which you can find and adjust by clicking on "blue light filter" in your display settings menu, to the left of the on/off toggle switch. Turning it all the way up (to the right) tones down the whites and blues without impacting the rest of the colors on the screen, which for me at least creates a much better color display ratio.