Develop Bugs

[MOD] Custom camera HAL with 4K UHD/DCI and 30 FPS video recording [Apr. 22, 2016]

Code:
/*
* Your warranty is... still valid?
*
* I am not responsible for bricked devices, dead SD cards,
* thermonuclear war, or you getting fired because the alarm app failed. Please
* do some research if you have any concerns about features included in this mod
* before flashing it! YOU are choosing to make these modifications, and if
* you point the finger at me for messing up your device, I will laugh at you.
*
*/
Installing this mod will give you the ability to record 4K UHD/DCI videos on your OnePlus X, as well as record videos at a consistent 30 frames per second in all lighting conditions (no more frame drops/stuttering when recording videos at night). This mod is compatible with most ROMs.
This is a custom camera HAL I created using CAF's vanilla camera HAL sources. As a lot of reverse engineering was involved in this, there are some caveats (see below).
Do NOT install this on my CM13 ROM!
Note that some ROMs using older proprietary camera libraries (such as the newest version of H2OS) will not benefit from 30 FPS video or my anti-shake algorithm.
If the 4K option does not appear in the camera app you're using, or your camera stops working, then clear data for the camera app that you're using.
Notable features:
4K UHD and DCI video recording
Consistent 30 FPS video recording in all lighting conditions
Intelligent anti-shake algorithm (significantly reduces motion blur when capturing photos)
Faster autofocus in low lighting conditions
No stuttering in camera viewfinder
Improved photo quality
Photo capture up to 4208x3120 resolution (instead of 4160x3120)
Caveats:
No ClearImage
No manual mode only in the OnePlus Camera app (other apps that support manual ISO and manual exposure work fine)
Installation instructions:
Install the 60 Hz Anti-banding file if you are in any of the following countries:
American Samoa
Anguilla
Antigua
Aruba
Bahamas
Belize
Bermuda
Brazil
Canada
Cayman Islands
Colombia
Costa Rica
Cuba
Dominican Republic
Ecuador
El Salvador
Guam
Guatemala
Guyana
Haiti
Honduras
Liberia
Mexico
Micronesia
Montserrat Islands
Nicaragua
Okinawa
Palmyra Atoll
Panama
Peru
Philippines
Puerto Rico
St. Kitts & Nevis Islands
Saudi Arabia
South Korea
Suriname
Tahiti
Taiwan
Trinidad & Tobago
United States
Venezuela
Virgin Islands
Instructions:
Download the camera HAL and copy it to your device
Reboot to recovery
Install the camera HAL
OPTIONAL install the 60 Hz Anti-banding file ONLY if you are in any of the countries listed above
Reboot
Downloads:
Camera HAL: http://forum.xda-developers.com/devdb/project/dl/?id=18115
60 Hz Anti-banding: http://forum.xda-developers.com/devdb/project/dl/?id=17356
XDA:DevDB Information
Custom camera HAL for OPX, Device Specific App for the OnePlus X
Contributors
Sultanxda
Version Information
Status: Stable
Created 2016-02-15
Last Updated 2016-08-10

Changelog:
April 22, 2016:
*Fixed slow-motion recording in the OnePlus Camera app (for OxygenOS)
*Fixed delay when moving camera while recording high-speed and slow-motion videos
*Fewer frames are dropped when recording high-speed and slow-motion videos now
April 20, 2016:
*Fixed blue tint when recording slow-motion and high-speed videos (60 FPS and 120 FPS videos)
April 17, 2016:
*Made anti-shake algorithm even less aggressive (images are less noisy and better quality now)
March 26, 2016:
*Made anti-shake algorithm less aggressive (images are less noisy and better quality now)
*Reduced JPEG quality to 95% (image files are smaller with no visible impact to quality)
*Improved image clarity
March 13, 2016:
*Fixed anti-banding setting in camera apps
*Set default anti-banding mode to 50 Hz (for Europe)
*Added flashable zip to change default anti-banding mode to 60 Hz (for the USA; see the installation instructions for details)
*Fixed rare flashing in camera viewfinder
March 7, 2016:
*Fixed graphical glitches when using HDR
*Fixed graphical glitches when taking photos with the front camera
*Fixed many other minor bugs
March 6, 2016:
*Fixed noisy HDR photos
*Fixed incorrect maker, model, and aperture displayed in image info
March 5, 2016:
*Fixed HDR
*Fixed manual exposure control
*Fixed manual ISO control
February 26, 2016:
*Implemented stronger, more intelligent anti-shake algorithm (significantly reduces motion blur when capturing photos)
*Fixed Panorama mode not working in Google Camera after recording video
*Fixed Photo Sphere mode not working in Google Camera after recording video
*Fixed photo capture not working while recording 4K video
February 22, 2016:
*Fixed compatibility with H2OS (note: 30 FPS video is not guaranteed in H2OS, as well as some out-of-date ROMs)
*Fixed long delay when turning off the flashlight in some ROMs
*Fixed long delay when switching between the front and back camera in some ROMs
*Improved image sharpness and clarity
February 16, 2016:
*Fixed compatibility with all ROMs
February 15, 2016:
*Initial release

Reserved

will test this soon and hope it works. you will be saviour for us.

saurabh40629 said:
will test this soon and hope it works. you will be saviour for us.
Click to expand...
Click to collapse
I tested it on CM12.1 and OxygenOS 2.2.0, and it appears to be working. Tested 4k UHD recording in Google Camera and it works.
The 4k video option won't show up in the OxygenOS camera app until you clear data for the app.
Let's see how this goes :silly:

Holy crap the legendary sultan developing for the one x?!?! Any plans for a oneplus x rom as well?

Super nice, waiting for Manuel Camera Controls as said in the post but this is already awesome

Sultanxda said:
I tested it on CM12.1 and OxygenOS 2.2.0, and it appears to be working. Tested 4k UHD recording in Google Camera and it works.
The 4k video option won't show up in the OxygenOS camera app until you clear data for the app.
Let's see how this goes :silly:
Click to expand...
Click to collapse
Because of Enormously crappy camera videos, I was having thoughts of selling this one. Seems like my money is saved. Kudos to you. :highfive:

If the camera had the capability to record to 4k,why didn't one plus include it in oos?

Flashed on temasek v4.0 and had a bootloop after that. Needed to reflash the rom.

sathyakaushik4 said:
If the camera had the capability to record to 4k,why didn't one plus include it in oos?
Click to expand...
Click to collapse
They didn't know how to fix it. There's a software bug with 4k on Snapdragon 800/801 chips that causes the 4k video to record at 7 FPS. This is a very difficult bug to fix (took me weeks to originally fix it on my OPO), so it isn't surprising that they decided to move on to other things instead of trying to solve it.
mieru said:
Flashed on temasek v4.0 and had a bootloop after that. Needed to reflash the rom.
Click to expand...
Click to collapse
The media_profiles.xml that comes with my package probably has some things in it that your ROM doesn't like. I'll have to test it myself to get a log so I can fix it.
surronix said:
Holy crap the legendary sultan developing for the one x?!?! Any plans for a oneplus x rom as well?
Click to expand...
Click to collapse
Not enough time/energy/motivation for that right now. Have a camera HAL instead

Sultanxda said:
They didn't know how to fix it. There's a software bug with 4k on Snapdragon 800/801 chips that causes the 4k video to record at 7 FPS. This is a very difficult bug to fix (took me weeks to originally fix it on my OPO), so it isn't surprising that they decided to move on to other things instead of trying to solve .
Click to expand...
Click to collapse
Don't they scout for talent on these Developer forum's if they have such dumb people sitting and developing ?
I heard a lot about you from my colleagues on OPO( obviously positive things )..... Welcome here :fingers-crossed::good:

rockuppl said:
Don't they scout for talent on these Developer forum's if they have such dumb people sitting and developing ?
I heard a lot about you from my colleagues on OPO( obviously positive things )..... Welcome here :fingers-crossed::good:
Click to expand...
Click to collapse
they already looked for sultan
but since he hasnt grad yet they didnt hire
edit: well thats what they said on AMA

Morning
Any open-source plans? Or can't you share because of reverse engineering? Will test soon
EDIT: UHD works fine and everything else also good work

getting back to OxygenOS to try it !!! Super job Sultan

Nailed it!
@Sultanxda, add to the 1st post that slowmotion mode on OOS camera app won't perform as expected. Didn't tested much, but it seems it is recording at 30fps.
It does not bothers me at all. Being possible to record at night is a big step forward.

Any samples? I'm getting to the point to install a custom recovery. I don't care about HDR or clear Image at all.

Just testing it.
I flashed it over OOS 2.2.0 with blu_spark v91.
Gonna upload some samples soon.
EDIT: https://www.youtube.com/watch?v=T_XYeGpFoJ0&list=PL7yFwUHsKYLHcLn21xGdwthFPJUL9SZXX&index=2

To cool to be true !!!
How can we hit 20 times Thanks button at a time ?

Damn this looks great!
can someone post sample in low light and picture quality?

Wide Vine Support / Netflix HD?

I was considering buying this phone or the mi 8, but I would like to ask users here regarding Xiaomi support about this feature,
Does Mi MIx 2 / 2S with latest firmware update support the wide vine level 1? this is needed in order to stream Netflix in HD,
You can check this using the DRM Info app on the play store,
Thanks in advances

goldenrealm said:
I was considering buying this phone or the mi 8, but I would like to ask users here regarding Xiaomi support about this feature,
Does Mi MIx 2 / 2S with latest firmware update support the wide vine level 1? this is needed in order to stream Netflix in HD,
You can check this using the DRM Info app on the play store,
Thanks in advances
Click to expand...
Click to collapse
Here you go

Mackay53 said:
Here you go
Click to expand...
Click to collapse
Thank you!
This is rather disappointing though with no L1 wide vine support yet

goldenrealm said:
Thank you!
This is rather disappointing though with no L1 wide vine support yet
Click to expand...
Click to collapse
My bootloader is unlocked so not sure if that will affect anything, I know on Sony phones the widevine is affected when its unlocked.

Mackay53 said:
My bootloader is unlocked so not sure if that will affect anything, I know on Sony phones the widevine is affected when its unlocked.
Click to expand...
Click to collapse
I see, I do plan to unlock the boot loader to root the phone, thanks anyway

Update WW_16.1210.1906.156_0

Update WW_16.1210.1906.156_0
Size 398,6 MB
June security patch
1. Enabled ARCore
2. Improved Video Call Experience
3. Camera; Enabled 8X zoom in Photo mode
Did anyone notice any other changes?
I received the update today, but one reviewer already on June 29th.
https://www.asus.com/cz/Phone/ZenFone-6-ZS630KL/HelpDesk_BIOS/

At first glance "Asus launcher stopped working" when switching apps through Recent apps button with Animations set to Off is fixed (that was my biggest complaint with this device). The phone feels more fluid, responsive and fast with this update. WW 6GB/ 128GB version here.

_jis_ said:
Update WW_16.1210.1906.156_0
Size 398,6 MB
June security patch
1. Enabled ARCore
2. Improved Video Call Experience
3. Camera; Enabled 8X zoom in Photo mode
Did anyone notice any other changes?
I received the update today, but one reviewer already on June 29th.
https://www.asus.com/cz/Phone/ZenFone-6-ZS630KL/HelpDesk_BIOS/
Click to expand...
Click to collapse
More change log in zentalk
https://zentalk.asus.com/en/discussion/7024/190625-zenfone-6-zs630kl-ww-16-1210-1906-156#latest
1. Enabled ARCore
2. Improved Video Call Experience
3. Camera; Enabled 8X zoom in Photo mode
4. Camera; Removed the time limit for FHD video recording
5. Camera; Added the function: to start/stop video recording with Volume Keys in Camera app
6. Optimized Screenshot Stability and solved bug related to screenshot functionality
7. Enabled TaiwanMobile VoWiFi
8. Camera; Improved Photo Image Quality on Noice Reduction
9. Camera; Improved Camera Flipping Stability
10. Updated Security Patch to June, 2019
11. Updated Translation Strings in Settings

Night mode is improved.
They tuned the saturation as well per user feedback.
Taking screenshots in Instagram feed using the different options is also now fixed.

_jis_ said:
Taking screenshots in Instagram feed using the different options is also now fixed.
Click to expand...
Click to collapse
What do you mean.. what kind of options.

_jis_ said:
Update WW_16.1210.1906.156_0
Size 398,6 MB
June security patch
1. Enabled ARCore
2. Improved Video Call Experience
3. Camera; Enabled 8X zoom in Photo mode
Did anyone notice any other changes?
I received the update today, but one reviewer already on June 29th.
https://www.asus.com/cz/Phone/ZenFone-6-ZS630KL/HelpDesk_BIOS/
Click to expand...
Click to collapse
Is this for a specific region?

mammenj said:
Is this for a specific region?
Click to expand...
Click to collapse
No, but it is a stagged release, see this: https://zentalk.asus.com/en/discussion/7024/190625-zenfone-6-zs630kl-ww-16-1210-1906-156
Since the server pushes update notice to different serial numbers by batches, it may take some days for you to receive the FOTA notice. Thanks for your patience.
Click to expand...
Click to collapse

prakharbirla said:
What do you mean.. what kind of options.
Click to expand...
Click to collapse
You can take a screenshot normal way or as a complete long screen, you can push two HW buttons or tap to quick settings tile or long tap to recent SW button...

Does redmi Note 8 Pro support widevine l1 and Netflix hd?

Since the ap for the Redmi Note 8 Pro is MediaTek, I wonder if it supports Netflix hd and widevine l1.

Not chinese version...
We have to wait for global version and see...
As Note 7 global has it, Note 8 Pro should....

@Plumplum88
And this is implemented in Hardware or in software?
A Global Rom flashed in to a Chinese RN8pro
would enabled it?

Tmv_Josue said:
@Plumplum88
And this is implemented in Hardware or in software?
A Global Rom flashed in to a Chinese RN8pro
would enabled it?
Click to expand...
Click to collapse
I think software as my older Oppo A3 was released without and get it with update
I can confirm Note 8 Pro sold in France has L1...

I have Netflix on my EU rom, but I don't know if it support HD.
Netflix come with ROM default app..like bloatware

Hi, for the owners of the Xiaomi redmi note 8 pro, French and European version, it would be interesting to know what DRM Info says about Widevine? At least there would be certainty of the L1. Thank you in advance to those who will do the test.

I got global version, bought in Poland, and I am sad to say that it shows widevine L3. It has a limit of 580p video from netflix, doesn't matter if you stream or download. Youtube though works nice with 60fps and HDR.

Hello everyone, I am a user and owner of a redmi note 8 pro 128gb/ 6gb GLOBAL. and I am sorry to say that according to the drm info apk the terminal has L1, however when opening netflix, the maximum resolution supported is 540p, and without having the HD logo enabled when viewing series or movie info, ... on the other hand Youtube Apk works great at 1080p60fps.

Netflix and Amazon prime video won't play HD content on RN8P
I am facing some issues with using Streaming services with RN8P. The DRM Info says the global variant of Redmi note 8 pro has widewine L1 certifications but the Netflix app says the L3 certifications and same case with Prime video,

hi,
i have the global version from the redmi note 8 pro.
DRM Info App Shows Widevine L1 and in Netflix it shows HD content!

UK purchased global version. DRM info app says L1 Netflix says L3
Ian

irhur said:
UK purchased global version. DRM info app says L1 Netflix says L3
Ian
Click to expand...
Click to collapse
Hey, have you tried this apk of Netflix? It may work on other devices other than POCO phone f1 which is what I have, after installing I did notice it was in HD.
https://forum.xda-developers.com/poco-f1/how-to/guide-to-netflix-hd-hd-dolby-5-1-t3951698

Thanks for this info. Have tried it but not sure quality was any better.

Adlon said:
hi,
i have the global version from the redmi note 8 pro.
DRM Info App Shows Widevine L1 and in Netflix it shows HD content!
Click to expand...
Click to collapse
What software version are you on and when good you get your phone?

hd or not hd
bungie240 said:
Hey, have you tried this apk of Netflix? It may work on other devices other than POCO phone f1 which is what I have, after installing I did notice it was in HD.
https://forum.xda-developers.com/poco-f1/how-to/guide-to-netflix-hd-hd-dolby-5-1-t3951698
Click to expand...
Click to collapse
So if you go in your netflix app and click on:
-more
-app settings
scroll down, and tap on:
-playback specification
what do you see in the second line? widewine: L1 or L3?
also, underneath: what does it say for your maximum playback resolution?

nagymancs said:
So if you go in your netflix app and click on:
-more
-app settings
scroll down, and tap on:
-playback specification
what do you see in the second line? widewine: L1 or L3?
also, underneath: what does it say for your maximum playback resolution?
Click to expand...
Click to collapse
I saw L3 there on the latest version of Netflix

Sadly L3 for me. Was hoping latest update would change this, but sadly not. SD is maximum resolution for me.

There's a specific apk of netflix which shows L1 on netflix.

HDR on Amazon Prime video app?

Hi there!
Some of you can play hdr content on Amazon prime video? The 7T is supposed to be certified but the maximum quality I can get is fullHD.
Back on November the option was there (settings-quality-streaming) which was 5.8GB/h but it disappeared three weeks ago. Now, the maximum is 1.8GB/h (fullHD).
Thanks.

Nobody with Amazon prime video? Really?

I am happy to check, but I honestly don't know how?

Not present
Just checked it's stuck at 1.8GB/Hr ! Any way to bring it back to 5GB / Hr ?

Cowbell_Guy said:
I am happy to check, but I honestly don't know how?
Click to expand...
Click to collapse
It's quite simple. Play a video with hdr option (the boys, the man in the hight castle, Jack Ryan, carnival row...).
While you are playing it (over WiFi if you can) touch the screen and under the duration bar you will see the resolution (hd, hd 1080 or hdr).
Or you can go to settings-qualitity-streaming (or download) and you should see something above 5GB/h.

swaroopce said:
Just checked it's stuck at 1.8GB/Hr ! Any way to bring it back to 5GB / Hr ?
Click to expand...
Click to collapse
I think is related to Amazon. This happens since they updated the app back on November (blue icon instead of white).
I cannot find the APK corresponding to the October version.

Pantumaca said:
I think is related to Amazon. This happens since they updated the app back on November (blue icon instead of white).
I cannot find the APK corresponding to the October version.
Click to expand...
Click to collapse
I just tried installing last 3 builds from Apkmirror and can confirm all 3 had same 1.8GB / Hr.
Sep build was worse as it has 460mb/hr.
Everytime I tried installing a new build, deleted all the cache and trace files of previous installation and proceeded. No luck

Update on 27th January 2020
I recently purchase the OnePlus 7T - HDR works on Netflix & YouTube. However, doesn't work on PrimeVideo app.
I had a chat with someone from the Amazon Support, here's an excerpt from that conversation (AgentName redacted) -
AgentName: Right now, Phones which has the Widevine L1 certification are able to access the videos in HD format only.
AgentName: Currently, HDR is not introduced in Prime Video app.
Me: Is that a region specific thing?
AgentName: We're adding the support for the phone one by one.
Me: Okay. Is there a list of phones that have already received the support? Something that will keep getting updated so that we can figure out which devices are now compatible
AgentName: We are working on this to adding the support for the phone one by one.
AgentName: To help you out, I've forwarded your expectations to our Prime videos Development Team so that they will look into this and may come up with HDR support for your phone in future updates.
Me: Okay. Thank you for your time AgentName. That's all I needed.
I think OnePlus should've done some work with these companies to ensure that their devices get HDR on these platforms before they mass produce and sell them. Hopefully this issue will be resolved soon. :fingers-crossed: